Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

cache: handle all possible initialization cases #7556

Merged
merged 1 commit into from
Feb 26, 2021
Merged

cache: handle all possible initialization cases #7556

merged 1 commit into from
Feb 26, 2021

Conversation

vmg
Copy link
Collaborator

@vmg vmg commented Feb 26, 2021 •
edited by deepthi
Loading

Description

It was just an over-eager check. Unit tests have been introduced

Related Issue(s)

Checklist

  • Should this PR be backported?
  • Tests were added or are not required
  • Documentation was added or is not required

Deployment Notes

Impacted Areas in Vitess

Components that this PR will affect:

  • Query Serving
  • VReplication
  • Cluster Management
  • Build/CI
  • VTAdmin

@vmg
cache: handle all possible initialization cases
a5e24b3 
Signed-off-by: Vicent Marti <vmg@strn.cat>
deepthi
deepthi approved these changes Feb 26, 2021
View reviewed changes
Copy link
Member

@deepthi deepthi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@deepthi deepthi merged commit f47f73c into vitessio:master Feb 26, 2021
@askdba askdba added this to the v10.0 milestone Mar 4, 2021
@deepthi deepthi mentioned this pull request Mar 12, 2021
Open
@ajm188 ajm188 mentioned this pull request Jul 14, 2021
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@deepthi deepthi deepthi approved these changes

Assignees
No one assigned
Labels
Component: Cluster management Component: Query Serving
Projects
None yet
Milestone
v10.0
Development

Successfully merging this pull request may close these issues.

panic from LFU cache when cache_size is set to 0
3 participants
@vmg @deepthi @askdba