Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[vtctld] Add v0 GetWorkflows rpc and workflow/vexec packages #7575

Merged
merged 20 commits into from
Mar 4, 2021
Merged

[vtctld] Add v0 GetWorkflows rpc and workflow/vexec packages #7575

merged 20 commits into from
Mar 4, 2021

Commits on Mar 2, 2021

  1. Organize vtctldata.proto and regenerate 

    Signed-off-by: Andrew Mason <amason@slack-corp.com>
    @ajm188
    ajm188 committed Mar 2, 2021
    Configuration menu
    Copy the full SHA
    59b1a2c View commit details
    Browse the repository at this point in the history

  2. wip - add GetWorkflows rpc, with some TODOs for later, and generate… 

    … everything

Signed-off-by: Andrew Mason <amason@slack-corp.com>
    @ajm188
    ajm188 committed Mar 2, 2021
    Configuration menu
    Copy the full SHA
    d0fdcca View commit details
    Browse the repository at this point in the history

  3. wip - first stab at a workflow/vexec API outside of wrangler 

    This will require a significant amount of polish, testing, and
documentation. I'll also need to see if it even works at all with how
wrangler currently does vexec queries.

Signed-off-by: Andrew Mason <amason@slack-corp.com>
    @ajm188
    ajm188 committed Mar 2, 2021
    Configuration menu
    Copy the full SHA
    0680c19 View commit details
    Browse the repository at this point in the history

  4. wip - move some files around, trying to get closer to good boundaries 

    Signed-off-by: Andrew Mason <amason@slack-corp.com>
    @ajm188
    ajm188 committed Mar 2, 2021
    Configuration menu
    Copy the full SHA
    bf9a306 View commit details
    Browse the repository at this point in the history

  5. wip - add workflow.Manager to VtctldServer, add CLI entrypoint 

    Signed-off-by: Andrew Mason <amason@slack-corp.com>
    @ajm188
    ajm188 committed Mar 2, 2021
    Configuration menu
    Copy the full SHA
    40b8fef View commit details
    Browse the repository at this point in the history

  6. [vtctl/workflow] wip - touch up error handling, add more designy comm… 

    …ents

Signed-off-by: Andrew Mason <amason@slack-corp.com>
    @ajm188
    ajm188 committed Mar 2, 2021
    Configuration menu
    Copy the full SHA
    2ccf392 View commit details
    Browse the repository at this point in the history

  7. [vtctl/workflow] - wip, allow threading a workflow through VExec 

    This is to support individual workflow queries, instead of just bulk
queries on multiple workflows (i.e. `GetWorkflow` vs `GetWorkflows`, or
`workflow ks.workflowname show` in the old API)

Signed-off-by: Andrew Mason <amason@slack-corp.com>
    @ajm188
    ajm188 committed Mar 2, 2021
    Configuration menu
    Copy the full SHA
    62f825b View commit details
    Browse the repository at this point in the history

  8. [vtctl/vexec] wip - set timeouts on topo calls 

    Signed-off-by: Andrew Mason <amason@slack-corp.com>
    @ajm188
    ajm188 committed Mar 2, 2021
    Configuration menu
    Copy the full SHA
    52d4a09 View commit details
    Browse the repository at this point in the history

  9. [vexec] wip - thread workflow name through to QueryPlan, update error… 

    …s/logs

Signed-off-by: Andrew Mason <amason@slack-corp.com>
    @ajm188
    ajm188 committed Mar 2, 2021
    Configuration menu
    Copy the full SHA
    3381daf View commit details
    Browse the repository at this point in the history

  10. [vexec] wip - add support for planning updates/deletes in vrep 

    This matches the old implementation, based on the constant values that
are always set for that version's planner.params() function. Note also
that in the old implementation, `planner.params().insertTemplates == nil`,
so `buildInsertPlan` would always return error, which is why we don't
even bother to define a function for it here. Only schema migration
workflows seem to support inserts.

Signed-off-by: Andrew Mason <amason@slack-corp.com>
    @ajm188
    ajm188 committed Mar 2, 2021
    Configuration menu
    Copy the full SHA
    5153020 View commit details
    Browse the repository at this point in the history

  11. [vexec] wip - move error definitions to files that use them most, gro… 

    …up them

Signed-off-by: Andrew Mason <amason@slack-corp.com>
    @ajm188
    ajm188 committed Mar 2, 2021
    Configuration menu
    Copy the full SHA
    77868fc View commit details
    Browse the repository at this point in the history

  12. [wrangler] wip - rewrite ListAllWorkflows in wrangler to use new vexec 

    Signed-off-by: Andrew Mason <amason@slack-corp.com>
    @ajm188
    ajm188 committed Mar 2, 2021
    Configuration menu
    Copy the full SHA
    6c9dfd0 View commit details
    Browse the repository at this point in the history

  13. [vexec] refactors and all the docs 

    Signed-off-by: Andrew Mason <amason@slack-corp.com>
    @ajm188
    ajm188 committed Mar 2, 2021
    Configuration menu
    Copy the full SHA
    630c037 View commit details
    Browse the repository at this point in the history

  14. [vexec] Move QueryPlan and methods to its own file 

    Signed-off-by: Andrew Mason <amason@slack-corp.com>
    @ajm188
    ajm188 committed Mar 2, 2021
    Configuration menu
    Copy the full SHA
    ed6136b View commit details
    Browse the repository at this point in the history

  15. [vexec] Add VReplicationQueryPlanner tests 

    Signed-off-by: Andrew Mason <amason@slack-corp.com>
    @ajm188
    ajm188 committed Mar 2, 2021
    Configuration menu
    Copy the full SHA
    e2fda5c View commit details
    Browse the repository at this point in the history

  16. [vexec] Add tests for QueryPlans 

    Signed-off-by: Andrew Mason <amason@slack-corp.com>
    @ajm188
    ajm188 committed Mar 2, 2021
    Configuration menu
    Copy the full SHA
    105160f View commit details
    Browse the repository at this point in the history

  17. [workflow] Document Manager, sort of 

    Signed-off-by: Andrew Mason <amason@slack-corp.com>
    @ajm188
    ajm188 committed Mar 2, 2021
    Configuration menu
    Copy the full SHA
    8b49191 View commit details
    Browse the repository at this point in the history

  18. [workflow] Rename, I decided I dislike "Server" slightly less as a ge… 

    …neric than "Manager"

Signed-off-by: Andrew Mason <amason@slack-corp.com>
    @ajm188
    ajm188 committed Mar 2, 2021
    Configuration menu
    Copy the full SHA
    358cfa3 View commit details
    Browse the repository at this point in the history

Commits on Mar 3, 2021

  1. [workflow] Rename (Shard)ReplicationStatus => (Shard)Stream 

    Signed-off-by: Andrew Mason <amason@slack-corp.com>
    @ajm188
    ajm188 committed Mar 3, 2021
    Configuration menu
    Copy the full SHA
    098ac4f View commit details
    Browse the repository at this point in the history

Commits on Mar 4, 2021

  1. fix typo 

    Signed-off-by: Andrew Mason <amason@slack-corp.com>
    @ajm188
    ajm188 committed Mar 4, 2021
    Configuration menu
    Copy the full SHA
    30f4750 View commit details
    Browse the repository at this point in the history