Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Addition of waitSig pprof argument to start recording on USR1 #7616

Merged
merged 1 commit into from
Mar 5, 2021

Conversation

frouioui
Copy link
Member

@frouioui frouioui commented Mar 5, 2021

Description

After running long benchmarks while profiling Vitess, the profiles start to get too big for go tool pprof and return an EOF error. To counterattack this issue, we decided to stop recording at any given time by using #7594, and without affecting the benchmarks.

However, we also want to control when to start recording. In the case of the benchmarks, we often have long preparation times where we insert and "warm-up" the system before practicing the actual benchmark. This is what this pull request brings: start recording at any given moment based on a received signal (USR1).

cc @vmg

Related Issue(s)

Checklist

  • Should this PR be backported?
  • Tests were added or are not required
  • Documentation was added or is not required

Impacted Areas in Vitess

Components that this PR will affect:

  • Query Serving
  • VReplication
  • Cluster Management
  • Build/CI
  • VTAdmin

Signed-off-by: Florent Poinsard <florent.poinsard@outlook.fr>
@frouioui frouioui requested a review from deepthi as a code owner March 5, 2021 09:22
Copy link
Collaborator

@vmg vmg left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Very nice refactoring.

@deepthi deepthi merged commit af89c42 into vitessio:master Mar 5, 2021
@askdba askdba added this to the v10.0 milestone Mar 10, 2021
@frouioui frouioui deleted the start-pprof-on-signal branch July 12, 2023 08:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants