Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Socket system variable to return vitess mysql socket #7637

Merged
merged 7 commits into from
Mar 10, 2021
Merged

Socket system variable to return vitess mysql socket #7637

merged 7 commits into from
Mar 10, 2021

Conversation

harshit-gangal
Copy link
Member

Description

Currently select @@socket returns socket file path of any vttablet. The change returns the socket path of vitess mysql socket path that can be used to connect to VTGate. Also, added logic to handle set socket = <some_path> at vtgate level.

Related Issue(s)

Checklist

  • Tests were added or are not required
  • Documentation was added or is not required

Impacted Areas in Vitess

Components that this PR will affect:

  • Query Serving

@harshit-gangal
added socket ast rewritter test
e3d59e0 
Signed-off-by: Harshit Gangal <harshit@planetscale.com>
@harshit-gangal
added socket in sysvars
b3f7fe5 
Signed-off-by: Harshit Gangal <harshit@planetscale.com>
@harshit-gangal
sysvar read only planner
630fb2c 
Signed-off-by: Harshit Gangal <harshit@planetscale.com>
@harshit-gangal
handled @@socket to return mysql server socket path of vtgate
786a269 
Signed-off-by: Harshit Gangal <harshit@planetscale.com>
@harshit-gangal
e2e and executor test for socket sysvar
ce69034 
Signed-off-by: Harshit Gangal <harshit@planetscale.com>
@systay
small fixes
5bef929 
Signed-off-by: Andres Taylor <andres@planetscale.com>
@systay
tweak test expectation
b1b2e82 
Signed-off-by: Andres Taylor <andres@planetscale.com>
@systay systay merged commit 9f5e7e5 into vitessio:master Mar 10, 2021
@systay systay deleted the sysvar-socket branch March 10, 2021 07:36
@askdba askdba added this to the v10.0 milestone Mar 10, 2021
@ajm188 ajm188 mentioned this pull request Jul 15, 2021
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@systay systay systay approved these changes

@GuptaManan100 GuptaManan100 Awaiting requested review from GuptaManan100

Assignees
No one assigned
Labels
Component: Query Serving
Projects
None yet
Milestone
v10.0
Development

Successfully merging this pull request may close these issues.

Support @@socket better
3 participants
@harshit-gangal @systay @askdba