Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix dual table query when system schema is selected database #7734

Merged
merged 3 commits into from
Mar 29, 2021
Merged

Fix dual table query when system schema is selected database #7734

merged 3 commits into from
Mar 29, 2021

Conversation

harshit-gangal
Copy link
Member

@harshit-gangal harshit-gangal commented Mar 24, 2021 •
edited
Loading

Description

If a system schema is selected as a database the dual query fails

use `mysql`;
select @@max_allowed_packet from dual;
ERROR: "keyspace mysql not found in vschema"

The fix is to send to any keyspace if default is system schema.

Checklist

  • Tests were added or are not required
  • Documentation was added or is not required

Impacted Areas in Vitess

Components that this PR will affect:

  • Query Serving

@harshit-gangal
added planbuilder test case
e8b1db3 
Signed-off-by: Harshit Gangal <harshit@planetscale.com>
@harshit-gangal
get any keyspace if system schema is default keyspace
d58b562 
Signed-off-by: Harshit Gangal <harshit@planetscale.com>
@harshit-gangal
added e2e test
dd30d84 
Signed-off-by: Harshit Gangal <harshit@planetscale.com>
@harshit-gangal harshit-gangal changed the title Fix sys dual Fix dual table query when system schema is selected database Mar 24, 2021
@systay systay merged commit 583e5ad into vitessio:master Mar 29, 2021
@systay systay deleted the fix-sys-dual branch March 29, 2021 06:16
@askdba askdba added this to the v10.0 milestone Apr 1, 2021
@ajm188 ajm188 mentioned this pull request Jul 15, 2021
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@systay systay systay approved these changes

Assignees
No one assigned
Labels
Component: Query Serving
Projects
None yet
Milestone
v10.0
Development

Successfully merging this pull request may close these issues.
3 participants
@harshit-gangal @systay @askdba