Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[tablet, queryrules] Extend query rules to check comments #7784

Merged
merged 9 commits into from
Apr 19, 2021
Merged

[tablet, queryrules] Extend query rules to check comments #7784

merged 9 commits into from
Apr 19, 2021

Commits on Apr 15, 2021

  1. leading+trailing comment regex + file watch 

    Signed-off-by: Richard Bailey <rbailey@slack-corp.com>
    @setassociative
    setassociative committed Apr 15, 2021
    Configuration menu
    Copy the full SHA
    cee8673 View commit details
    Browse the repository at this point in the history

  2. route query comments into GetAction call; let filterbyplan continue t… 

    …o work as expected

Signed-off-by: Richard Bailey <rbailey@slack-corp.com>
    @setassociative
    setassociative committed Apr 15, 2021
    Configuration menu
    Copy the full SHA
    f7ee920 View commit details
    Browse the repository at this point in the history

  3. fix tests, register to cancel the watch 

    Signed-off-by: Richard Bailey <rbailey@slack-corp.com>
    @setassociative
    setassociative committed Apr 15, 2021
    Configuration menu
    Copy the full SHA
    149ef10 View commit details
    Browse the repository at this point in the history

  4. copy/paste bug 

    Signed-off-by: Richard Bailey <rbailey@slack-corp.com>
    @setassociative
    setassociative committed Apr 15, 2021
    Configuration menu
    Copy the full SHA
    5f4e981 View commit details
    Browse the repository at this point in the history

  5. extend support for rulesctl + swap to battle tested file watch 

    Signed-off-by: Richard Bailey <rbailey@slack-corp.com>
    @setassociative
    setassociative committed Apr 15, 2021
    Configuration menu
    Copy the full SHA
    3999ade View commit details
    Browse the repository at this point in the history

  6. Simplify GetAction / remove log calls 

    Signed-off-by: Richard Bailey <rbailey@slack-corp.com>
    @setassociative
    setassociative committed Apr 15, 2021
    Configuration menu
    Copy the full SHA
    47783c2 View commit details
    Browse the repository at this point in the history

  7. gofmt 

    Signed-off-by: Richard Bailey <rbailey@slack-corp.com>
    @setassociative
    setassociative committed Apr 15, 2021
    Configuration menu
    Copy the full SHA
    1db363c View commit details
    Browse the repository at this point in the history

  8. Remove no longer necessary file stub creation 

    Fix bug in how we attach RE to the rule in rulesctl

Signed-off-by: Richard Bailey <rbailey@slack-corp.com>
    @setassociative
    setassociative committed Apr 15, 2021
    Configuration menu
    Copy the full SHA
    19cb23e View commit details
    Browse the repository at this point in the history

  9. make sizegen 

    Signed-off-by: Richard Bailey <rbailey@slack-corp.com>
    @setassociative
    setassociative committed Apr 15, 2021
    Configuration menu
    Copy the full SHA
    54898e7 View commit details
    Browse the repository at this point in the history