Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Online DDL plan via Send; "singleton" migrations on tablets #7785

Merged
merged 77 commits into from
Apr 22, 2021
Merged

Online DDL plan via Send; "singleton" migrations on tablets #7785

merged 77 commits into from
Apr 22, 2021

Commits on Apr 1, 2021

  1. support vitess Comments in CREATE/ALTER/DROP TABLE statements 

    Signed-off-by: Shlomi Noach <2607934+shlomi-noach@users.noreply.github.com>
    @shlomi-noach
    shlomi-noach committed Apr 1, 2021
    Configuration menu
    Copy the full SHA
    0a5c2b1 View commit details
    Browse the repository at this point in the history

  2. improved upon comment_opt in CREATE, ALTER and DROP statements 

    Signed-off-by: Shlomi Noach <2607934+shlomi-noach@users.noreply.github.com>
    @shlomi-noach
    shlomi-noach committed Apr 1, 2021
    Configuration menu
    Copy the full SHA
    a5b39a2 View commit details
    Browse the repository at this point in the history

Commits on Apr 2, 2021

  1. normalized comments for DROP statements 

    Signed-off-by: Shlomi Noach <2607934+shlomi-noach@users.noreply.github.com>
    @shlomi-noach
    shlomi-noach committed Apr 2, 2021
    Configuration menu
    Copy the full SHA
    1234cab View commit details
    Browse the repository at this point in the history

  2. minor comment spacing change 

    Signed-off-by: Shlomi Noach <2607934+shlomi-noach@users.noreply.github.com>
    @shlomi-noach
    shlomi-noach committed Apr 2, 2021
    Configuration menu
    Copy the full SHA
    be290ef View commit details
    Browse the repository at this point in the history

  3. Merge remote-tracking branch 'origin/online-ddl-idempotent' into onli… 

    …ne-ddl-send-plan-comments

Signed-off-by: Shlomi Noach <2607934+shlomi-noach@users.noreply.github.com>
    @shlomi-noach
    shlomi-noach committed Apr 2, 2021
    Configuration menu
    Copy the full SHA
    db392d7 View commit details
    Browse the repository at this point in the history

Commits on Apr 3, 2021

  1. DDL statement: SetComments 

    Signed-off-by: Shlomi Noach <2607934+shlomi-noach@users.noreply.github.com>
    @shlomi-noach
    shlomi-noach committed Apr 3, 2021
    Configuration menu
    Copy the full SHA
    ef5172f View commit details
    Browse the repository at this point in the history

Commits on Apr 5, 2021

  1. online ddl refactor: 

    - introducing DDLStrategySetting, formal wrapper for strategy+options
- NewOnlineDDLs generates multiple OnlineDDL from a given statement, instead of parser generating multiple statements
- OnlineDDL utilizes DDLStrategySetting; some logic moved out from OnlineDDL and into DDLStrategySetting

Signed-off-by: Shlomi Noach <2607934+shlomi-noach@users.noreply.github.com>
    @shlomi-noach
    shlomi-noach committed Apr 5, 2021
    Configuration menu
    Copy the full SHA
    cf8d855 View commit details
    Browse the repository at this point in the history

  2. TabletExecutor utilizes DDLStrategySetting, now more DRY and more for… 

    …mal; also uses NewOnlineDDLs to break down queries

Signed-off-by: Shlomi Noach <2607934+shlomi-noach@users.noreply.github.com>
    @shlomi-noach
    shlomi-noach committed Apr 5, 2021
    Configuration menu
    Copy the full SHA
    552b50a View commit details
    Browse the repository at this point in the history

  3. vtctl utilizes new DDLStrategySetting 

    Signed-off-by: Shlomi Noach <2607934+shlomi-noach@users.noreply.github.com>
    @shlomi-noach
    shlomi-noach committed Apr 5, 2021
    Configuration menu
    Copy the full SHA
    6df2060 View commit details
    Browse the repository at this point in the history

  4. onlineddl.Executor utilizes new DDLStrategySetting. Also, it ensures … 

    …to clean up VT comments from query

Signed-off-by: Shlomi Noach <2607934+shlomi-noach@users.noreply.github.com>
    @shlomi-noach
    shlomi-noach committed Apr 5, 2021
    Configuration menu
    Copy the full SHA
    8fd6222 View commit details
    Browse the repository at this point in the history

  5. endtoend tests adapt to new DDLStrategySetting 

    Signed-off-by: Shlomi Noach <2607934+shlomi-noach@users.noreply.github.com>
    @shlomi-noach
    shlomi-noach committed Apr 5, 2021
    Configuration menu
    Copy the full SHA
    6d4db17 View commit details
    Browse the repository at this point in the history

  6. go.sum 

    Signed-off-by: Shlomi Noach <2607934+shlomi-noach@users.noreply.github.com>
    @shlomi-noach
    shlomi-noach committed Apr 5, 2021
    Configuration menu
    Copy the full SHA
    852e9a7 View commit details
    Browse the repository at this point in the history

  7. utilizing DDLStrategySetting to validate @@ddl_strategy 

    Signed-off-by: Shlomi Noach <2607934+shlomi-noach@users.noreply.github.com>
    @shlomi-noach
    shlomi-noach committed Apr 5, 2021
    Configuration menu
    Copy the full SHA
    63fac67 View commit details
    Browse the repository at this point in the history

  8. adapt to DDLStrategySetting 

    Signed-off-by: Shlomi Noach <2607934+shlomi-noach@users.noreply.github.com>
    @shlomi-noach
    shlomi-noach committed Apr 5, 2021
    Configuration menu
    Copy the full SHA
    7124709 View commit details
    Browse the repository at this point in the history

  9. adapt to DDLStrategySetting 

    Signed-off-by: Shlomi Noach <2607934+shlomi-noach@users.noreply.github.com>
    @shlomi-noach
    shlomi-noach committed Apr 5, 2021
    Configuration menu
    Copy the full SHA
    1e4ace2 View commit details
    Browse the repository at this point in the history

  10. OnlineDDL engine can choose to use Send to pus online DDL statements,… 

    … instead of writing them to topo. It utilizes new DDLStrategySetting, and uses samd TaretDestination as non-online DDL engine.

Signed-off-by: Shlomi Noach <2607934+shlomi-noach@users.noreply.github.com>
    @shlomi-noach
    shlomi-noach committed Apr 5, 2021
    Configuration menu
    Copy the full SHA
    dfe69b0 View commit details
    Browse the repository at this point in the history

  11. merge master, resolve conflicts 

    Signed-off-by: Shlomi Noach <2607934+shlomi-noach@users.noreply.github.com>
    @shlomi-noach
    shlomi-noach committed Apr 5, 2021
    Configuration menu
    Copy the full SHA
    580393b View commit details
    Browse the repository at this point in the history

  12. REVERT supports comment_opt 

    Signed-off-by: Shlomi Noach <2607934+shlomi-noach@users.noreply.github.com>
    @shlomi-noach
    shlomi-noach committed Apr 5, 2021
    Configuration menu
    Copy the full SHA
    9c60403 View commit details
    Browse the repository at this point in the history

  13. NewOnlineDDL now expects DDLStatement. NewOnlineDDLBySQL supports an … 

    …SQL string, but validates that it parses as a DDLStatement

Signed-off-by: Shlomi Noach <2607934+shlomi-noach@users.noreply.github.com>
    @shlomi-noach
    shlomi-noach committed Apr 5, 2021
    Configuration menu
    Copy the full SHA
    b637c0b View commit details
    Browse the repository at this point in the history

  14. RevertMigration prints comments in Format, supports SetComments() 

    Signed-off-by: Shlomi Noach <2607934+shlomi-noach@users.noreply.github.com>
    @shlomi-noach
    shlomi-noach committed Apr 5, 2021
    Configuration menu
    Copy the full SHA
    4271063 View commit details
    Browse the repository at this point in the history

  15. removed 'NewOnlineDDLBySQL()' introduced in previous commit. NewOnlin… 

    …eDDL now parses query and expects either DDLStatement or RevertMigration

Signed-off-by: Shlomi Noach <2607934+shlomi-noach@users.noreply.github.com>
    @shlomi-noach
    shlomi-noach committed Apr 5, 2021
    Configuration menu
    Copy the full SHA
    55e3c31 View commit details
    Browse the repository at this point in the history

  16. revert schema.NewOnlineDDLBySQL 

    Signed-off-by: Shlomi Noach <2607934+shlomi-noach@users.noreply.github.com>
    @shlomi-noach
    shlomi-noach committed Apr 5, 2021
    Configuration menu
    Copy the full SHA
    617656a View commit details
    Browse the repository at this point in the history

  17. formalizing 'revert <uuid>' into 'revert vitess_migration '<uuid>'' 

    Signed-off-by: Shlomi Noach <2607934+shlomi-noach@users.noreply.github.com>
    @shlomi-noach
    shlomi-noach committed Apr 5, 2021
    Configuration menu
    Copy the full SHA
    417c1c4 View commit details
    Browse the repository at this point in the history

Commits on Apr 6, 2021

  1. support legacy revert statement parser; only generate new formal reve… 

    …rt statement on IsSkipTopo()

Signed-off-by: Shlomi Noach <2607934+shlomi-noach@users.noreply.github.com>
    @shlomi-noach
    shlomi-noach committed Apr 6, 2021
    Configuration menu
    Copy the full SHA
    cc2aa00 View commit details
    Browse the repository at this point in the history

  2. vtgate/plan: revert uses Send when IsSkipTopo() 

    Signed-off-by: Shlomi Noach <2607934+shlomi-noach@users.noreply.github.com>
    @shlomi-noach
    shlomi-noach committed Apr 6, 2021
    Configuration menu
    Copy the full SHA
    e3d29b6 View commit details
    Browse the repository at this point in the history

  3. initial implementation for RevertMigration plan in tabletserver 

    Signed-off-by: Shlomi Noach <2607934+shlomi-noach@users.noreply.github.com>
    @shlomi-noach
    shlomi-noach committed Apr 6, 2021
    Configuration menu
    Copy the full SHA
    beaff22 View commit details
    Browse the repository at this point in the history

  4. merge master, resolve conflicts 

    Signed-off-by: Shlomi Noach <2607934+shlomi-noach@users.noreply.github.com>
    @shlomi-noach
    shlomi-noach committed Apr 6, 2021
    Configuration menu
    Copy the full SHA
    3c00298 View commit details
    Browse the repository at this point in the history

  5. sizegen 

    Signed-off-by: Shlomi Noach <2607934+shlomi-noach@users.noreply.github.com>
    @shlomi-noach
    shlomi-noach committed Apr 6, 2021
    Configuration menu
    Copy the full SHA
    3736bf2 View commit details
    Browse the repository at this point in the history

  6. encode online DDL params using encoding/hex to safeguard against pote… 

    …ntial quotes and spaces in text. OnlineDDLFromCommentedStatement() function reads a commented statement and reconstructs an OnlineDDL instance

Signed-off-by: Shlomi Noach <2607934+shlomi-noach@users.noreply.github.com>
    @shlomi-noach
    shlomi-noach committed Apr 6, 2021
    Configuration menu
    Copy the full SHA
    2badbcf View commit details
    Browse the repository at this point in the history

  7. DDLStatement supports GetComments() 

    Signed-off-by: Shlomi Noach <2607934+shlomi-noach@users.noreply.github.com>
    @shlomi-noach
    shlomi-noach committed Apr 6, 2021
    Configuration menu
    Copy the full SHA
    45508e0 View commit details
    Browse the repository at this point in the history

  8. extra sanity check for UUID 

    Signed-off-by: Shlomi Noach <2607934+shlomi-noach@users.noreply.github.com>
    @shlomi-noach
    shlomi-noach committed Apr 6, 2021
    Configuration menu
    Copy the full SHA
    f593408 View commit details
    Browse the repository at this point in the history

  9. go.sum 

    Signed-off-by: Shlomi Noach <2607934+shlomi-noach@users.noreply.github.com>
    @shlomi-noach
    shlomi-noach committed Apr 6, 2021
    Configuration menu
    Copy the full SHA
    268b233 View commit details
    Browse the repository at this point in the history

  10. only remove comments temporarily 

    Signed-off-by: Shlomi Noach <2607934+shlomi-noach@users.noreply.github.com>
    @shlomi-noach
    shlomi-noach committed Apr 6, 2021
    Configuration menu
    Copy the full SHA
    250dc5a View commit details
    Browse the repository at this point in the history

  11. run online DDL from within vttablet/query executor 

    Signed-off-by: Shlomi Noach <2607934+shlomi-noach@users.noreply.github.com>
    @shlomi-noach
    shlomi-noach committed Apr 6, 2021
    Configuration menu
    Copy the full SHA
    6a675e4 View commit details
    Browse the repository at this point in the history

  12. removed redundant field 

    Signed-off-by: Shlomi Noach <2607934+shlomi-noach@users.noreply.github.com>
    @shlomi-noach
    shlomi-noach committed Apr 6, 2021
    Configuration menu
    Copy the full SHA
    f44fa0d View commit details
    Browse the repository at this point in the history

  13. triggering next check upon SubmitMigration 

    Signed-off-by: Shlomi Noach <2607934+shlomi-noach@users.noreply.github.com>
    @shlomi-noach
    shlomi-noach committed Apr 6, 2021
    Configuration menu
    Copy the full SHA
    5697f17 View commit details
    Browse the repository at this point in the history

  14. -skip-topo flag 

    Signed-off-by: Shlomi Noach <2607934+shlomi-noach@users.noreply.github.com>
    @shlomi-noach
    shlomi-noach committed Apr 6, 2021
    Configuration menu
    Copy the full SHA
    ae7ab35 View commit details
    Browse the repository at this point in the history

Commits on Apr 7, 2021

  1. fix timestamp 

    Signed-off-by: Shlomi Noach <2607934+shlomi-noach@users.noreply.github.com>
    @shlomi-noach
    shlomi-noach committed Apr 7, 2021
    Configuration menu
    Copy the full SHA
    8e0c77d View commit details
    Browse the repository at this point in the history

  2. Adding tabletmanager.ExecuteQuery() which runs QueryExecutor.Execute(… 

    …) for arbitrary queries; support for same in TabletManagerClient. Tablet executor utilizes the above to apply -skip-topo schema changes on tabletmanager

Signed-off-by: Shlomi Noach <2607934+shlomi-noach@users.noreply.github.com>
    @shlomi-noach
    shlomi-noach committed Apr 7, 2021
    Configuration menu
    Copy the full SHA
    4374d24 View commit details
    Browse the repository at this point in the history

Commits on Apr 8, 2021

  1. reject -singleton migratio submission if another migration is pending 

    Signed-off-by: Shlomi Noach <2607934+shlomi-noach@users.noreply.github.com>
    @shlomi-noach
    shlomi-noach committed Apr 8, 2021
    Configuration menu
    Copy the full SHA
    885de27 View commit details
    Browse the repository at this point in the history

  2. onlineddl/singleton endtoend tests 

    Signed-off-by: Shlomi Noach <2607934+shlomi-noach@users.noreply.github.com>
    @shlomi-noach
    shlomi-noach committed Apr 8, 2021
    Configuration menu
    Copy the full SHA
    453d2ef View commit details
    Browse the repository at this point in the history

  3. cleanup 

    Signed-off-by: Shlomi Noach <2607934+shlomi-noach@users.noreply.github.com>
    @shlomi-noach
    shlomi-noach committed Apr 8, 2021
    Configuration menu
    Copy the full SHA
    a8c3111 View commit details
    Browse the repository at this point in the history

  4. ApplySchema supports 'revert vitess_migration' queries 

    Signed-off-by: Shlomi Noach <2607934+shlomi-noach@users.noreply.github.com>
    @shlomi-noach
    shlomi-noach committed Apr 8, 2021
    Configuration menu
    Copy the full SHA
    895693c View commit details
    Browse the repository at this point in the history

  5. testing REVERT statements on vtctl 

    Signed-off-by: Shlomi Noach <2607934+shlomi-noach@users.noreply.github.com>
    @shlomi-noach
    shlomi-noach committed Apr 8, 2021
    Configuration menu
    Copy the full SHA
    2771b09 View commit details
    Browse the repository at this point in the history

  6. skip_preflight 

    Signed-off-by: Shlomi Noach <2607934+shlomi-noach@users.noreply.github.com>
    @shlomi-noach
    shlomi-noach committed Apr 8, 2021
    Configuration menu
    Copy the full SHA
    585b373 View commit details
    Browse the repository at this point in the history

  7. fixed endtoendt test 

    Signed-off-by: Shlomi Noach <2607934+shlomi-noach@users.noreply.github.com>
    @shlomi-noach
    shlomi-noach committed Apr 8, 2021
    Configuration menu
    Copy the full SHA
    22ae22c View commit details
    Browse the repository at this point in the history

Commits on Apr 11, 2021

  1. Merge branch 'master' into online-ddl-send-plan-comments 

    Signed-off-by: Shlomi Noach <2607934+shlomi-noach@users.noreply.github.com>
    @shlomi-noach
    shlomi-noach committed Apr 11, 2021
    Configuration menu
    Copy the full SHA
    c206a5d View commit details
    Browse the repository at this point in the history

Commits on Apr 12, 2021

  1. Merge branch 'master' into online-ddl-send-plan-comments 

    Signed-off-by: Shlomi Noach <2607934+shlomi-noach@users.noreply.github.com>
    @shlomi-noach
    shlomi-noach committed Apr 12, 2021
    Configuration menu
    Copy the full SHA
    359490b View commit details
    Browse the repository at this point in the history

Commits on Apr 13, 2021

  1. Merge branch 'master' into online-ddl-send-plan-comments 

    Signed-off-by: Shlomi Noach <2607934+shlomi-noach@users.noreply.github.com>
    @shlomi-noach
    shlomi-noach committed Apr 13, 2021
    Configuration menu
    Copy the full SHA
    66015d9 View commit details
    Browse the repository at this point in the history

  2. merged master, resolve conflict 

    Signed-off-by: Shlomi Noach <2607934+shlomi-noach@users.noreply.github.com>
    @shlomi-noach
    shlomi-noach committed Apr 13, 2021
    Configuration menu
    Copy the full SHA
    684fbd3 View commit details
    Browse the repository at this point in the history

Commits on Apr 18, 2021

  1. merged master, resolve conflict 

    Signed-off-by: Shlomi Noach <2607934+shlomi-noach@users.noreply.github.com>
    @shlomi-noach
    shlomi-noach committed Apr 18, 2021
    Configuration menu
    Copy the full SHA
    29ef369 View commit details
    Browse the repository at this point in the history

Commits on Apr 20, 2021

  1. merged master, resolve conflict 

    Signed-off-by: Shlomi Noach <2607934+shlomi-noach@users.noreply.github.com>
    @shlomi-noach
    shlomi-noach committed Apr 20, 2021
    Configuration menu
    Copy the full SHA
    226ba67 View commit details
    Browse the repository at this point in the history

  2. apply /etc/hosts patch 

    Signed-off-by: Shlomi Noach <2607934+shlomi-noach@users.noreply.github.com>
    @shlomi-noach
    shlomi-noach committed Apr 20, 2021
    Configuration menu
    Copy the full SHA
    479525a View commit details
    Browse the repository at this point in the history

  3. extend CI port range 

    Signed-off-by: Shlomi Noach <2607934+shlomi-noach@users.noreply.github.com>
    @shlomi-noach
    shlomi-noach committed Apr 20, 2021
    Configuration menu
    Copy the full SHA
    fdbdf06 View commit details
    Browse the repository at this point in the history

  4. extend CI port range: apply 

    Signed-off-by: Shlomi Noach <2607934+shlomi-noach@users.noreply.github.com>
    @shlomi-noach
    shlomi-noach committed Apr 20, 2021
    Configuration menu
    Copy the full SHA
    b5127c5 View commit details
    Browse the repository at this point in the history

  5. Merge branch 'master' into online-ddl-send-plan-comments 

    Signed-off-by: Shlomi Noach <2607934+shlomi-noach@users.noreply.github.com>
    @shlomi-noach
    shlomi-noach committed Apr 20, 2021
    Configuration menu
    Copy the full SHA
    eb1a784 View commit details
    Browse the repository at this point in the history

  6. copyright year 

    Signed-off-by: Shlomi Noach <2607934+shlomi-noach@users.noreply.github.com>
    @shlomi-noach
    shlomi-noach committed Apr 20, 2021
    Configuration menu
    Copy the full SHA
    3737c8f View commit details
    Browse the repository at this point in the history

  7. clarifies case statement 

    Signed-off-by: Shlomi Noach <2607934+shlomi-noach@users.noreply.github.com>
    @shlomi-noach
    shlomi-noach committed Apr 20, 2021
    Configuration menu
    Copy the full SHA
    ed94bb9 View commit details
    Browse the repository at this point in the history

  8. vterrors 

    Signed-off-by: Shlomi Noach <2607934+shlomi-noach@users.noreply.github.com>
    @shlomi-noach
    shlomi-noach committed Apr 20, 2021
    Configuration menu
    Copy the full SHA
    2f81d42 View commit details
    Browse the repository at this point in the history

  9. patch OS fo rupgrade test 

    Signed-off-by: Shlomi Noach <2607934+shlomi-noach@users.noreply.github.com>
    @shlomi-noach
    shlomi-noach committed Apr 20, 2021
    Configuration menu
    Copy the full SHA
    942ad9b View commit details
    Browse the repository at this point in the history

  10. more verbose execution of vtctlclient 

    Signed-off-by: Shlomi Noach <2607934+shlomi-noach@users.noreply.github.com>
    @shlomi-noach
    shlomi-noach committed Apr 20, 2021
    Configuration menu
    Copy the full SHA
    f027d46 View commit details
    Browse the repository at this point in the history

  11. Merge branch 'master' into online-ddl-send-plan-comments 

    Signed-off-by: Shlomi Noach <2607934+shlomi-noach@users.noreply.github.com>
    @shlomi-noach
    shlomi-noach committed Apr 20, 2021
    Configuration menu
    Copy the full SHA
    ff49712 View commit details
    Browse the repository at this point in the history

Commits on Apr 21, 2021

  1. -skip_preflight must be v9.0.0 compatible 

    Signed-off-by: Shlomi Noach <2607934+shlomi-noach@users.noreply.github.com>
    @shlomi-noach
    shlomi-noach committed Apr 21, 2021
    Configuration menu
    Copy the full SHA
    051bb2a View commit details
    Browse the repository at this point in the history

  2. Merge branch 'master' into online-ddl-send-plan-comments 

    Signed-off-by: Shlomi Noach <2607934+shlomi-noach@users.noreply.github.com>
    @shlomi-noach
    shlomi-noach committed Apr 21, 2021
    Configuration menu
    Copy the full SHA
    e06d1b8 View commit details
    Browse the repository at this point in the history

  3. Merge branch 'master' into online-ddl-send-plan-comments 

    Signed-off-by: Shlomi Noach <2607934+shlomi-noach@users.noreply.github.com>
    @shlomi-noach
    shlomi-noach committed Apr 21, 2021
    Configuration menu
    Copy the full SHA
    5cd4a09 View commit details
    Browse the repository at this point in the history

  4. empty commit to kick CI 

    Signed-off-by: Shlomi Noach <2607934+shlomi-noach@users.noreply.github.com>
    @shlomi-noach
    shlomi-noach committed Apr 21, 2021
    Configuration menu
    Copy the full SHA
    86f4b27 View commit details
    Browse the repository at this point in the history

  5. empty commit to kick CI 

    Signed-off-by: Shlomi Noach <2607934+shlomi-noach@users.noreply.github.com>
    @shlomi-noach
    shlomi-noach committed Apr 21, 2021
    Configuration menu
    Copy the full SHA
    10d95ad View commit details
    Browse the repository at this point in the history

Commits on Apr 22, 2021

  1. more verbose logging on 'xtrabackup failed with error' 

    Signed-off-by: Shlomi Noach <2607934+shlomi-noach@users.noreply.github.com>
    @shlomi-noach
    shlomi-noach committed Apr 22, 2021
    Configuration menu
    Copy the full SHA
    09e3e90 View commit details
    Browse the repository at this point in the history

  2. experiment: sleep 20sec 

    Signed-off-by: Shlomi Noach <2607934+shlomi-noach@users.noreply.github.com>
    @shlomi-noach
    shlomi-noach committed Apr 22, 2021
    Configuration menu
    Copy the full SHA
    86fa94b View commit details
    Browse the repository at this point in the history

  3. lower sleep 

    Signed-off-by: Shlomi Noach <2607934+shlomi-noach@users.noreply.github.com>
    @shlomi-noach
    shlomi-noach committed Apr 22, 2021
    Configuration menu
    Copy the full SHA
    cab62e2 View commit details
    Browse the repository at this point in the history

  4. 10 secs 

    Signed-off-by: Shlomi Noach <2607934+shlomi-noach@users.noreply.github.com>
    @shlomi-noach
    shlomi-noach committed Apr 22, 2021
    Configuration menu
    Copy the full SHA
    54a4721 View commit details
    Browse the repository at this point in the history

  5. 20 secs 

    Signed-off-by: Shlomi Noach <2607934+shlomi-noach@users.noreply.github.com>
    @shlomi-noach
    shlomi-noach committed Apr 22, 2021
    Configuration menu
    Copy the full SHA
    036cb43 View commit details
    Browse the repository at this point in the history

  6. 30 secs 

    Signed-off-by: Shlomi Noach <2607934+shlomi-noach@users.noreply.github.com>
    @shlomi-noach
    shlomi-noach committed Apr 22, 2021
    Configuration menu
    Copy the full SHA
    4512c31 View commit details
    Browse the repository at this point in the history

  7. sleep on terminatedRestore 

    Signed-off-by: Shlomi Noach <2607934+shlomi-noach@users.noreply.github.com>
    @shlomi-noach
    shlomi-noach committed Apr 22, 2021
    Configuration menu
    Copy the full SHA
    71d576f View commit details
    Browse the repository at this point in the history

  8. refactor switch statement per review 

    Signed-off-by: Shlomi Noach <2607934+shlomi-noach@users.noreply.github.com>
    @shlomi-noach
    shlomi-noach committed Apr 22, 2021
    Configuration menu
    Copy the full SHA
    7397b8b View commit details
    Browse the repository at this point in the history

  9. fixed race condition 

    Signed-off-by: Shlomi Noach <2607934+shlomi-noach@users.noreply.github.com>
    @shlomi-noach
    shlomi-noach committed Apr 22, 2021
    Configuration menu
    Copy the full SHA
    34e0a4c View commit details
    Browse the repository at this point in the history

  10. reduce sleep time 

    Signed-off-by: Shlomi Noach <2607934+shlomi-noach@users.noreply.github.com>
    @shlomi-noach
    shlomi-noach committed Apr 22, 2021
    Configuration menu
    Copy the full SHA
    5bb8ffd View commit details
    Browse the repository at this point in the history