Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

CI: run some tests inside docker to workaround GH Actions issue #7868

Merged
merged 4 commits into from
Apr 14, 2021

Conversation

deepthi
Copy link
Member

@deepthi deepthi commented Apr 14, 2021

Description

Attempt to work-around GitHub Actions issues by running tests inside docker.

  • Unit tests can be run with the correct docker image because we publish bootstrap images for various flavors
  • There is a mismatch between flavors and docker images. The percona bootstrap image has now been tagged with percona56 and the mariadb image with mariadb101 to allow us to still run tests by flavor.
  • mariadb102 test has been temporarily removed. If docker becomes a permanent solution, we will need to build a new bootstrap image for this
  • Other failing tests (onlineddl, examples) etc. will run using the mysql57 image
  • Test run time goes up when running in docker. For example, unit tests take 9-10 minutes without docker, and 10-12 minutes with.
  • Increase timeout inside the test runner to 30 minutes. unit_test_race takes longer than 10 minutes.
  • By default the test runner runs each test 3 times, turn that off by setting retry=1
  • onlineddl_ghost and onlineddl_declarative will be overwritten if we run make generate_ci_workflows again, so we need to watch out for that.

Impacted Areas in Vitess

Components that this PR will affect:

  • Query Serving
  • VReplication
  • Cluster Management
  • Build/CI
  • VTAdmin

EDIT 4/16/21: There is an open issue on Actions actions/runner-images#3185

Signed-off-by: deepthi <deepthi@planetscale.com>
Signed-off-by: deepthi <deepthi@planetscale.com>
@deepthi deepthi changed the title CI: run unit tests inside docker CI: run some tests inside docker Apr 14, 2021
…increase timeout to 30 minutes

Signed-off-by: deepthi <deepthi@planetscale.com>
@deepthi deepthi requested a review from a team April 14, 2021 21:22
Signed-off-by: deepthi <deepthi@planetscale.com>
Copy link
Contributor

@rohit-nayak-ps rohit-nayak-ps left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm
brilliant idea :-)

@deepthi deepthi merged commit 2fd64d0 into vitessio:master Apr 14, 2021
@deepthi deepthi deleted the ds-docker-unit-tests branch April 14, 2021 21:59
@deepthi deepthi changed the title CI: run some tests inside docker CI: run some tests inside docker to workaround GH Actions issue Apr 16, 2021
deepthi added a commit to planetscale/vitess that referenced this pull request Apr 23, 2021
Signed-off-by: deepthi <deepthi@planetscale.com>
deepthi added a commit that referenced this pull request Apr 23, 2021
CI: Revert docker change for unit tests from #7868
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants