-
Notifications
You must be signed in to change notification settings - Fork 2.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix bug with reserved connections to stale tablets #7879
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Harshit Gangal <harshit@planetscale.com>
Signed-off-by: Andres Taylor <andres@planetscale.com>
Signed-off-by: Andres Taylor <andres@planetscale.com>
Signed-off-by: Andres Taylor <andres@planetscale.com>
Signed-off-by: Harshit Gangal <harshit@planetscale.com>
…ceived Signed-off-by: Harshit Gangal <harshit@planetscale.com>
Signed-off-by: Harshit Gangal <harshit@planetscale.com>
harshit-gangal
force-pushed
the
rc-t-fix
branch
from
April 18, 2021 17:41
911ddfc
to
968a32b
Compare
Signed-off-by: Harshit Gangal <harshit@planetscale.com>
Signed-off-by: Harshit Gangal <harshit@planetscale.com>
Signed-off-by: Harshit Gangal <harshit@planetscale.com>
harshit-gangal
force-pushed
the
rc-t-fix
branch
from
April 19, 2021 04:46
bdce2a3
to
e5de1c7
Compare
… traffic and also has valid target Signed-off-by: Harshit Gangal <harshit@planetscale.com>
… and were needed to be in sync Signed-off-by: Harshit Gangal <harshit@planetscale.com>
…ent tablet is not servicable without querying the tablet and using heathcheck at vtgate Signed-off-by: Harshit Gangal <harshit@planetscale.com>
…query service connection if it matches the criteria Signed-off-by: Harshit Gangal <harshit@planetscale.com>
…changed Signed-off-by: Harshit Gangal <harshit@planetscale.com>
harshit-gangal
requested review from
deepthi,
harshit-gangal,
rafael and
shlomi-noach
as code owners
April 19, 2021 18:58
Signed-off-by: Harshit Gangal <harshit@planetscale.com>
Signed-off-by: Andres Taylor <andres@planetscale.com>
Signed-off-by: Harshit Gangal <harshit@planetscale.com>
harshit-gangal
force-pushed
the
rc-t-fix
branch
from
April 20, 2021 09:41
137567d
to
7614155
Compare
harshit-gangal
requested review from
sougou
and removed request for
deepthi,
shlomi-noach and
harshit-gangal
April 20, 2021 17:11
deepthi
approved these changes
Apr 21, 2021
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM, a couple of nits
Signed-off-by: Andres Taylor <andres@planetscale.com>
Signed-off-by: Harshit Gangal <harshit@planetscale.com>
harshit-gangal
force-pushed
the
rc-t-fix
branch
from
April 22, 2021 07:11
3a2e62e
to
987b0ed
Compare
Signed-off-by: Harshit Gangal <harshit@planetscale.com>
harshit-gangal
force-pushed
the
rc-t-fix
branch
from
April 22, 2021 09:49
e15706b
to
a225828
Compare
2 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Make sure to reconnect reserved connections to tablets that are not answering any more.
Related Issue(s)
Fixes #7875
Checklist
Yes!
Impacted Areas in Vitess
Components that this PR will affect: