[vtadmin-web] Do not parse numbers/booleans in URL query parameters by default #8100
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…y default Signed-off-by: Sara Bee <855595+doeg@users.noreply.github.com>
doeg
changed the title
doeg
force-pushed
the
sarabee-vtadmin-filtering-defaults
branch
from
df6e0ed
to
1e74570
Compare
ajm188
approved these changes
May 12, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Signed-off-by: Sara Bee 855595+doeg@users.noreply.github.com
Description
Currently, VTAdmin by default parses numeric URL query parameters as numbers. This resulted in unintended behaviour with shard filtering, where filtering by a string like "000" (to, say, find shard
0001-0002) would be parsed as0(no leading zeroes) and would also evaluate as falsey, which caused a host of other unfun side-effects.In this screenshot, I tried to filter by "00". Note the
?filter=0in the URL and the empty text input:It turns out that not parsing booleans/numbers is the more common VTAdmin use case. The one exception so far is pagination, were we do want
page=1to parse as an integer.Here's what it looks like with the fix:
Related Issue(s)
N/A
Checklist
Deployment Notes
N/A