Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update do_release to work in the 9.0 branch #8184

Merged
merged 1 commit into from
May 25, 2021
Merged

Update do_release to work in the 9.0 branch #8184

merged 1 commit into from
May 25, 2021

Conversation

systay
Copy link
Collaborator

@systay systay commented May 25, 2021

Description

In the 9.0 branch, we are not using the version.go file, so it should not be created by the release script

@systay
Update do_release to work in the 9.0 branch
ffd4b9e 
Signed-off-by: Andres Taylor <andres@planetscale.com>
@systay systay requested a review from sougou as a code owner May 25, 2021 09:14
@systay systay requested review from askdba and removed request for sougou May 25, 2021 09:14
askdba
askdba approved these changes May 25, 2021
View reviewed changes
Copy link
Contributor

@askdba askdba left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@systay systay merged commit 9b94e51 into vitessio:release-9.0 May 25, 2021
@systay systay deleted the 9.0-release-script branch May 25, 2021 10:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@askdba askdba askdba approved these changes

Assignees
No one assigned
Labels
Component: Build/CI Type: CI/Build
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@systay @askdba