-
Notifications
You must be signed in to change notification settings - Fork 2.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Signed int parse #8189
Signed int parse #8189
Conversation
Signed-off-by: GuptaManan100 <manan@planetscale.com>
Signed-off-by: GuptaManan100 <manan@planetscale.com> Co-authored-by: frouioui <florent.poinsard@outlook.fr>
Does this need support in |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
We should not drop the signed/unsigned part in the AST
Signed-off-by: GuptaManan100 <manan@planetscale.com>
Signed-off-by: GuptaManan100 <manan@planetscale.com>
We are already storing the signed/unsigned part in the AST. Its just that signed is the default so it is dropped. Since we already had the functionality of storing this in AST, we do not require any changes to |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
sounds good
Description
The following query does not work correctly in the parser
This PR fixes it by adding the optional SIGNED token after the numeric type names.
Related Issue(s)
Fixes #8153
Checklist