-
Notifications
You must be signed in to change notification settings - Fork 2.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[vtctld] Add GetSrvVSchemas command #8221
Merged
ajm188
merged 4 commits into
vitessio:master
from
tinyspeck:sarabee-vtctld-getsrvvschemas
Jun 1, 2021
Merged
[vtctld] Add GetSrvVSchemas command #8221
ajm188
merged 4 commits into
vitessio:master
from
tinyspeck:sarabee-vtctld-getsrvvschemas
Jun 1, 2021
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Sara Bee <855595+doeg@users.noreply.github.com>
…f null Signed-off-by: Sara Bee <855595+doeg@users.noreply.github.com>
doeg
added
Component: VTAdmin
VTadmin interface
Type: Enhancement
Logical improvement (somewhere between a bug and feature)
labels
May 31, 2021
Signed-off-by: Sara Bee <855595+doeg@users.noreply.github.com>
Signed-off-by: Sara Bee <855595+doeg@users.noreply.github.com>
ajm188
approved these changes
Jun 1, 2021
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
lgtm (and thank you for adding the help texts to the others! ❤️ )
Merged
2 tasks
ajm188
added a commit
to tinyspeck/vitess
that referenced
this pull request
Jun 15, 2021
…vschemas [vtctld] Add GetSrvVSchemas command Signed-off-by: Andrew Mason <amason@slack-corp.com>
ajm188
added a commit
to tinyspeck/vitess
that referenced
this pull request
Jul 23, 2021
…vschemas [vtctld] Add GetSrvVSchemas command Signed-off-by: Andrew Mason <amason@slack-corp.com>
8 tasks
vmogilev
pushed a commit
to tinyspeck/vitess
that referenced
this pull request
May 23, 2022
…vschemas [vtctld] Add GetSrvVSchemas command Signed-off-by: Vitaliy Mogilevskiy <vmogilevskiy@slack-corp.com>
33 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
Component: Cluster management
Component: VTAdmin
VTadmin interface
Type: Enhancement
Logical improvement (somewhere between a bug and feature)
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Signed-off-by: Sara Bee 855595+doeg@users.noreply.github.com
Description
This is a precursor to adding an
/api/srvvschemas
endpoint to VTAdmin, which will return all of the SrvVSchemas for all cells (or optionally filtered by cell) in a cluster. #8208 was the first attempt at this, however: @ajm188 suggested adding this to the vtctld so that the vtctlds can query all of the topos in their region. This is more efficient than VTAdmin querying each individual cell.vtctldclient GetSrvVSchemas zone1
vtctldclient GetSrvVSchemas nope
vtctldclient GetSrvVSchemas zone1 nope
Related Issue(s)
Checklist
Deployment Notes
N/A