Gen4 fail more2 #8382
Merged
Gen4 fail more2 #8382
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Florent Poinsard <florent.poinsard@outlook.fr>
Signed-off-by: Florent Poinsard <florent.poinsard@outlook.fr>
Signed-off-by: Florent Poinsard <florent.poinsard@outlook.fr>
Signed-off-by: Florent Poinsard <florent.poinsard@outlook.fr>
Signed-off-by: Florent Poinsard <florent.poinsard@outlook.fr>
Signed-off-by: Florent Poinsard <florent.poinsard@outlook.fr>
Signed-off-by: Andres Taylor <andres@planetscale.com>
systay
added
Component: Query Serving
Type: Enhancement
Signed-off-by: Andres Taylor <andres@planetscale.com>
Signed-off-by: Andres Taylor <andres@planetscale.com>
Signed-off-by: Florent Poinsard <florent.poinsard@outlook.fr>
… joins Co-authored-by: Andres Taylor <andres@planetscale.com> Signed-off-by: Florent Poinsard <florent.poinsard@outlook.fr>
systay
commented
Jun 24, 2021
Signed-off-by: Florent Poinsard <florent.poinsard@outlook.fr>
frouioui
reviewed
Jun 28, 2021
| case sqlparser.SelectExprs: | ||
| if isParentSelect(cursor) { | ||
| a.inProjection = append(a.inProjection, true) | ||
| fmt.Println(len(a.inProjection)) |
GuptaManan100
approved these changes
Jun 28, 2021
| @@ -141,20 +141,31 @@ func (p parenTables) tableID() semantics.TableSet { | |||
| } | |||
|
|
|||
| // visit will traverse the route tables, going inside parenTables and visiting all routeTables | |||
There was a problem hiding this comment.
nit: change comment to match the function name
2 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This PR will make sure that the gen4 planner does one of the following:
Related Issue(s)
#7280
Continuation of #8359
Checklist