Gen4: Distinct plan refactor and support grouping and aggregation on join query #8506
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…rimitive to support varchar type columns Signed-off-by: Harshit Gangal <harshit@planetscale.com>
harshit-gangal
force-pushed
the
gen4-distinct-2
branch
from
db2488d
to
c8dd552
Compare
Signed-off-by: Harshit Gangal <harshit@planetscale.com>
Signed-off-by: Harshit Gangal <harshit@planetscale.com>
harshit-gangal
added
Component: Query Serving
Type: Enhancement
Signed-off-by: Harshit Gangal <harshit@planetscale.com>
…xpressions Signed-off-by: Harshit Gangal <harshit@planetscale.com>
Signed-off-by: Harshit Gangal <harshit@planetscale.com>
… on current scope it is not able to resolve Signed-off-by: Harshit Gangal <harshit@planetscale.com>
harshit-gangal
force-pushed
the
gen4-distinct-2
branch
from
5264a5f
to
9b54895
Compare
Signed-off-by: Harshit Gangal <harshit@planetscale.com>
harshit-gangal
changed the title
systay
reviewed
Jul 22, 2021
systay
reviewed
Jul 22, 2021
systay
reviewed
Jul 22, 2021
systay
approved these changes
Jul 22, 2021
Signed-off-by: Harshit Gangal <harshit@planetscale.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Refactored distinct plan to use oa engine.
Added additional supported plans or add failure messages for Gen4 errors to plan tests.
Added support for grouping, aggregations in join query.
Related Issue(s)
#7280
Checklist
Deployment Notes