Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Gen4: Adds support for comments and comment directives in Gen4 #8547

Merged
merged 1 commit into from
Jul 28, 2021

Conversation

GuptaManan100
Copy link
Member

@GuptaManan100 GuptaManan100 commented Jul 27, 2021

Description

This PR adds support for comments and comment directives in Gen4.

Related Issue(s)

#7280

Checklist

  • Tests were added or are not required
  • Documentation was added or is not required

Deployment Notes

…ective

Signed-off-by: GuptaManan100 <manan@planetscale.com>
@GuptaManan100 GuptaManan100 added Type: Enhancement Logical improvement (somewhere between a bug and feature) Component: Query Serving labels Jul 27, 2021
@systay
Copy link
Collaborator

systay commented Jul 27, 2021

I'll let @frouioui or @harshit-gangal also take a look before we merge

@harshit-gangal harshit-gangal self-assigned this Jul 28, 2021
@systay systay merged commit fbc61ab into vitessio:main Jul 28, 2021
@systay systay deleted the gen4-query-hints branch July 28, 2021 08:10
@harshit-gangal harshit-gangal changed the title Adds support for comments and comment directives in Gen4 Gen4: Adds support for comments and comment directives in Gen4 Oct 15, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Component: Query Serving Type: Enhancement Logical improvement (somewhere between a bug and feature)
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants