Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fixing a panic in vtgate with OLAP mode #8722

Merged
merged 6 commits into from
Sep 2, 2021
Merged

Fixing a panic in vtgate with OLAP mode #8722

merged 6 commits into from
Sep 2, 2021

Conversation

frouioui
Copy link
Member

@frouioui frouioui commented Aug 30, 2021 •
edited
Loading

Description

This pull request fixes a panic in vtgate that happens when a show tables or a use <database> query is sent to Vitess after entering olap mode.

Related Issue(s)

Fixes #8694

Checklist

  • Should this PR be backported?
  • Tests were added or are not required
  • Documentation was added or is not required

@frouioui
Addition of an end-to-end test to reproduce the panic of vitessio#8694
f531d22 
Signed-off-by: Florent Poinsard <florent.poinsard@outlook.fr>
@frouioui
Avoiding panic in RenameFields.renameFields method
43ce22f 
Signed-off-by: Florent Poinsard <florent.poinsard@outlook.fr>
@frouioui frouioui marked this pull request as draft August 30, 2021 09:23
@frouioui frouioui marked this pull request as ready for review August 30, 2021 09:29
@deepthi
Copy link
Member

deepthi commented Aug 30, 2021

Let's backport to 11.0 branch (and others if they are affected).

This was referenced Aug 31, 2021
Merged
Closed
Closed
@frouioui
Improved 8694 E2E test and for loop in renameFields
a168b4d 
Signed-off-by: Florent Poinsard <florent.poinsard@outlook.fr>
@frouioui
Fixing renameFields for loop logic
5532eba 
Signed-off-by: Florent Poinsard <florent.poinsard@outlook.fr>
@frouioui
Fixed loop logic erro
f8d411f 
Signed-off-by: Florent Poinsard <florent.poinsard@outlook.fr>
@harshit-gangal
added a fields len check in rename_fields engine to avoid renamefield…
e28cf40 
…s call

Signed-off-by: Harshit Gangal <harshit@planetscale.com>
@harshit-gangal harshit-gangal merged commit 332223c into vitessio:main Sep 2, 2021
@harshit-gangal harshit-gangal deleted the fix-8694 branch September 2, 2021 15:05
@deepthi deepthi mentioned this pull request Feb 25, 2023
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@harshit-gangal harshit-gangal harshit-gangal approved these changes

@systay systay Awaiting requested review from systay systay is a code owner

@aquarapid aquarapid Awaiting requested review from aquarapid

Assignees
No one assigned
Labels
Component: Query Serving Type: Bug
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Panic in vtgate with OLAP mode
3 participants
@frouioui @deepthi @harshit-gangal