-
Notifications
You must be signed in to change notification settings - Fork 2.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Changed parsing for unions #8821
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: ritwizsinha <ritwizsinha0@gmail.com>
Signed-off-by: ritwizsinha <ritwizsinha0@gmail.com>
Signed-off-by: ritwizsinha <ritwizsinha0@gmail.com>
Signed-off-by: Manan Gupta <manan@planetscale.com>
Signed-off-by: ritwizsinha <ritwizsinha0@gmail.com>
Signed-off-by: ritwizsinha <ritwizsinha0@gmail.com>
ritwizsinha
force-pushed
the
test-branch
branch
2 times, most recently
from
September 19, 2021 14:45
78ff634
to
1fc5d4e
Compare
Signed-off-by: ritwizsinha <ritwizsinha0@gmail.com>
ritwizsinha
force-pushed
the
test-branch
branch
from
September 20, 2021 04:30
a6a0c60
to
6491f02
Compare
Signed-off-by: ritwizsinha <ritwizsinha0@gmail.com>
Signed-off-by: ritwizsinha <ritwizsinha0@gmail.com>
Signed-off-by: ritwizsinha <ritwizsinha0@gmail.com>
Signed-off-by: ritwizsinha <ritwizsinha0@gmail.com>
Signed-off-by: Manan Gupta <manan@planetscale.com>
Signed-off-by: Manan Gupta <manan@planetscale.com>
Signed-off-by: Manan Gupta <manan@planetscale.com>
Signed-off-by: Manan Gupta <manan@planetscale.com>
Signed-off-by: Manan Gupta <manan@planetscale.com>
GuptaManan100
added
Component: Query Serving
Type: Enhancement
Logical improvement (somewhere between a bug and feature)
labels
Sep 20, 2021
Signed-off-by: Manan Gupta <manan@planetscale.com>
systay
reviewed
Sep 20, 2021
Signed-off-by: Manan Gupta <manan@planetscale.com>
GuptaManan100
requested review from
harshit-gangal and
shlomi-noach
as code owners
September 20, 2021 23:53
GuptaManan100
approved these changes
Sep 21, 2021
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM! 🤟
systay
reviewed
Sep 21, 2021
systay
approved these changes
Sep 21, 2021
18 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
Component: Query Serving
Type: Enhancement
Logical improvement (somewhere between a bug and feature)
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This pull request, makes changes to the select and union grammar in Vitess to match what is implemented in the MYSQL grammar. Here are the changes that have been made
is a parsing error and this type of query is only accepted if it is parenthesized
Related Issue(s)
Checklist
Deployment Notes