Handle mapping of gRPC packet overflows to ERTooManyUserConnections for SELECT cases too
#8853
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…, but only for inserts, selects of too much data would still report ERTooManyUserConnections Signed-off-by: Jacques Grove <aquarapid@gmail.com>
|
Is this ready to merge? |
systay
added a commit
that referenced
this pull request
Oct 7, 2021
Backport of #8853 for release 12.0
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #8852
See original PR #6630
This is a potential breaking change for those that depended on the old behavior of
ERTooManyUserConnectionsbeing returned on a too-largeSELECT, and mapped that to some application-side action.Not addressed in this PR, but we should probably add an end-to-end test here to catch if/when the upstream gRPC error message is ever changed, since we track upstream gRPC now after having been frozen for years.