fixed regression in v3 for grouping by integer functions #8856
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Manan Gupta <manan@planetscale.com>
Signed-off-by: Manan Gupta <manan@planetscale.com>
GuptaManan100
requested review from
harshit-gangal and
systay
as code owners
systay
approved these changes
Sep 22, 2021
systay
pushed a commit
to systay/vitess
that referenced
this pull request
Sep 22, 2021
This is a backport of vitessio#8856 The regression in the linked issue was found to be occurring from adding weight_string function due to order by as introduced in vitessio#7678. MySQL however does not support the generated query - ``` select ascii(val1) as a, count(*), weight_string(ascii(val1)) from aggr_test group by a order by a asc ``` In order to fix this, we should also add the weight_string function to the group by clause as follows - ``` select ascii(val1) as a, count(*), weight_string(ascii(val1)) from aggr_test group by a, weight_string(ascii(val1)) order by a asc ``` Fixes vitessio#8855 Signed-off-by: Manan Gupta <manan@planetscale.com> Signed-off-by: Andres Taylor <andres@planetscale.com>
This was referenced Sep 22, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
The regression in the linked issue was found to be occurring from adding weight_string function due to order by as introduced in #7678. MySQL however does not support the generated query -
In order to fix this, we should also add the weight_string function to the group by clause as follows -
This PR accomplishes this change
Related Issue(s)
Checklist
Deployment Notes