Prefix logger with keyspace/shard #8869
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Yang Wu <y.wu4515@gmail.com>
5antelope
added
Type: Enhancement
deepthi
reviewed
Sep 23, 2021
There was a problem hiding this comment.
Looks fine to me.
@aquarapid @sougou any concerns about this?
|
I need to fix the stackfram a bit :) |
Signed-off-by: Yang Wu <y.wu4515@gmail.com>
|
I think this is ready for review, thanks |
|
@aquarapid do you happen to have the permission to land this PR? would like to land it for the v12 release early next week. thanks! |
|
gentle nudge, thanks! |
|
If you really need this in v12 we can accept a PR on the release-12.0 branch (since this was approved several days ago but not merged in time). |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Signed-off-by: Yang Wu y.wu4515@gmail.com
Description
VTGR logs can be pretty hard to find the right one for a given shard. Often the time, we need know the host name and then grab logs from it.
This PR prefix all the VTGR logs with
shard=ks/shardso that it is easier to search.Related Issue(s)
^
Checklist
Deployment Notes