Add parsing for common table expressions using WITH clause #8918
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: ritwizsinha <ritwizsinha0@gmail.com>
ritwizsinha
requested review from
GuptaManan100,
harshit-gangal and
systay
as code owners
Signed-off-by: ritwizsinha <ritwizsinha0@gmail.com>
Signed-off-by: ritwizsinha <ritwizsinha0@gmail.com>
ritwizsinha
added
Component: Query Serving
Type: Enhancement
GuptaManan100
requested changes
Oct 8, 2021
Signed-off-by: ritwizsinha <ritwizsinha0@gmail.com>
Signed-off-by: Manan Gupta <manan@planetscale.com>
Signed-off-by: Manan Gupta <manan@planetscale.com>
Signed-off-by: Manan Gupta <manan@planetscale.com>
GuptaManan100
approved these changes
Oct 13, 2021
frouioui
approved these changes
Oct 14, 2021
Signed-off-by: ritwizsinha <ritwizsinha0@gmail.com>
harshit-gangal
approved these changes
Oct 18, 2021
Comment on lines
+36
to
+45
| switch node := selStatement.(type) { | ||
| case *sqlparser.Select: | ||
| if node.With != nil { | ||
| return nil, vterrors.New(vtrpcpb.Code_UNIMPLEMENTED, "unsupported: with expression in select statement") | ||
| } | ||
| case *sqlparser.Union: | ||
| if node.With != nil { | ||
| return nil, vterrors.New(vtrpcpb.Code_UNIMPLEMENTED, "unsupported: with expression in union statement") | ||
| } | ||
| } |
There was a problem hiding this comment.
nit: add the function on the SelectStatement interface.
18 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Updated grammar and formatting to add support for common table expressions
Related Issue(s)
Checklist
Deployment Notes