-
Notifications
You must be signed in to change notification settings - Fork 2.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Avoid some pollution of CLI argument namespace across vtgate and vttablet #8931
Conversation
in all the vttablet CLI flags into vtgate. Signed-off-by: Jacques Grove <aquarapid@gmail.com>
CLI flags with vtgate vault flags Signed-off-by: Jacques Grove <aquarapid@gmail.com>
Signed-off-by: Jacques Grove <aquarapid@gmail.com>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I know this is still in draft, but in case it's helpful, I wonder if it would be better to move the flag definitions into subpackages rather than the other way around? For example, what I'm starting to do here: f556f7d
Signed-off-by: Jacques Grove <aquarapid@gmail.com>
Yeah, that probably fair enough. But more surgery than I'm willing to commit to right now. |
Signed-off-by: Jacques Grove <aquarapid@gmail.com>
Signed-off-by: Jacques Grove <aquarapid@gmail.com>
For release notes:
|
This does not fix all instances of this problem, but it does improve the situation:
Before:
After:
The vttablet situation is still not great, but the remaining vttablet flags that are really vtgate-only are not easy to remove, e.g. the ones from
go/mysql
, like:which is not easy to break into sub-packages without import cycles; and will need greater surgery.