Fix for schema tracker not recognizing RENAME for schema reloading #8963
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Jacques Grove <aquarapid@gmail.com>
Signed-off-by: Jacques Grove <aquarapid@gmail.com>
aquarapid
changed the title
aquarapid
requested review from
harshit-gangal,
shlomi-noach and
systay
as code owners
sougou
approved these changes
Oct 12, 2021
There was a problem hiding this comment.
We should also have @systay or @harshit-gangal eyeball this.
|
@sougou This is not related to vtgate schema tracker, this is related to vreplication schema versioning :) |
|
gentle nudge, it would be great if we can land this so we can try it out :-) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
See #8960
Need to still think if there are other cases we should add tests for.