-
Notifications
You must be signed in to change notification settings - Fork 2.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[vtctl] command deprecations #8967
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The end-result is so readable!
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This is great!
Approving pre-emptively, I do think @doeg's comment needs to be addressed before we merge this.
Can you think of a reason why we should not port this to 12.0 before releasing it?
Signed-off-by: Andrew Mason <amason@slack-corp.com>
8d4f2cf
to
933908e
Compare
Agreed, and done.
Nope, I will port it over there as well! |
933908e
to
186f599
Compare
Signed-off-by: Andrew Mason <amason@slack-corp.com>
186f599
to
3186b12
Compare
[vtctl] command deprecations Signed-off-by: Andrew Mason <amason@slack-corp.com>
Description
This PR adds fields to the
command
struct to support more formalized deprecation of commands. Unfortunately this required me to update every single command, because we weren't using keyed structs, but that is now fixed as well.Examples:
Related Issue(s)
Fixes #8953.
Checklist
Deployment Notes