schema tracking: minimize logging of errors when loading keyspace with disabled schema tracking #8989
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Andres Taylor <andres@planetscale.com>
systay
force-pushed
the
quiest-schema-tracking
branch
from
aa5cfd7
to
6cb2ed2
Compare
…o such table error from vttablet Signed-off-by: Harshit Gangal <harshit@planetscale.com>
harshit-gangal
force-pushed
the
quiest-schema-tracking
branch
from
062e930
to
017607d
Compare
harshit-gangal
added
Component: Query Serving
release notes
Type: Enhancement
Signed-off-by: Harshit Gangal <harshit@planetscale.com>
frouioui
approved these changes
Oct 13, 2021
harshit-gangal
approved these changes
Oct 13, 2021
harshit-gangal
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
The schema tracker was trying to reload keyspaces over and over again, and logging errors every time. This PR changes so that when an error is received because the database or table is missing, we stop trying to reload the keyspace until we get an actual "schema changed" signal from the tablet.
Checklist