[vtctldserver] migrate ExecuteHook #9024
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
deepthi
reviewed
Oct 19, 2021
proto/vtctlservice.proto
Outdated
| @@ -79,6 +80,8 @@ service Vtctld { | |||
| // EmergencyReparentShard reparents the shard to the new primary. It assumes | |||
| // the old primary is dead or otherwise not responding. | |||
| rpc EmergencyReparentShard(vtctldata.EmergencyReparentShardRequest) returns (vtctldata.EmergencyReparentShardResponse) {}; | |||
| // ExecuteHook runs the hook on the tablet. | |||
| rpc ExecuteHook(vtctldata.ExecuteHookRequest) returns (tabletmanagerdata.ExecuteHookResponse); | |||
There was a problem hiding this comment.
This seems non-intuitive. IIUC, vtctldata.ExecuteHookRequest wraps around a tabletmanagerdata.ExecuteHookRequest. Was this done to avoid breaking cross-version compatibility?
There was a problem hiding this comment.
Huh, I thought we did this in more places in this file, but I guess that's just vtadmin.
The reason we're wrapping around is because we need to include the tablet alias with the actual hook request for the vtctld version. Then, we wrap the alias with the tabletmanagerdata request because protobuf won't let you embed structs/messages, and I don't want to copy-paste the fields in case they drift over time.
ajm188
force-pushed
the
grpcvtctldserver-migrate-executehook
branch
from
5598fc3
to
6f7971c
Compare
deepthi
approved these changes
Oct 29, 2021
ajm188
force-pushed
the
grpcvtctldserver-migrate-executehook
branch
from
6f7971c
to
9df0a29
Compare
Signed-off-by: Andrew Mason <amason@slack-corp.com>
Signed-off-by: Andrew Mason <amason@slack-corp.com>
Signed-off-by: Andrew Mason <amason@slack-corp.com>
Signed-off-by: Andrew Mason <amason@slack-corp.com>
ajm188
force-pushed
the
grpcvtctldserver-migrate-executehook
branch
from
9df0a29
to
04039a3
Compare
Protobuf messages marshal to json differently than pure Go structs, so I'm trying this out to see that has changed things in a way that is breaking endtoend tests Signed-off-by: Andrew Mason <amason@slack-corp.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This migrates ExecuteHook to vtctldserver and updates the legacy commands to use it.
Related Issue(s)
Closes #9023
Checklist
Deployment Notes