Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[vtctldserver] migrate ExecuteHook #9024

Merged
merged 6 commits into from
Oct 30, 2021
Merged

[vtctldserver] migrate ExecuteHook #9024

merged 6 commits into from
Oct 30, 2021

Commits on Oct 30, 2021

  1. Add ExecuteHook proto, regenerate, add stub 

    Signed-off-by: Andrew Mason <amason@slack-corp.com>
    @ajm188
    ajm188 committed Oct 30, 2021
    Configuration menu
    Copy the full SHA
    2e38cb4 View commit details
    Browse the repository at this point in the history

  2. Copy and adapt wrangler implementation for ExecuteHook 

    Signed-off-by: Andrew Mason <amason@slack-corp.com>
    @ajm188
    ajm188 committed Oct 30, 2021
    Configuration menu
    Copy the full SHA
    985e99f View commit details
    Browse the repository at this point in the history

  3. Add tests 

    Signed-off-by: Andrew Mason <amason@slack-corp.com>
    @ajm188
    ajm188 committed Oct 30, 2021
    Configuration menu
    Copy the full SHA
    42d9bdb View commit details
    Browse the repository at this point in the history

  4. Add cli entrypoint 

    Signed-off-by: Andrew Mason <amason@slack-corp.com>
    @ajm188
    ajm188 committed Oct 30, 2021
    Configuration menu
    Copy the full SHA
    2377fc1 View commit details
    Browse the repository at this point in the history

  5. Backport to legacy vtctl command, delete wrangler methods 

    Signed-off-by: Andrew Mason <amason@slack-corp.com>
    @ajm188
    ajm188 committed Oct 30, 2021
    Configuration menu
    Copy the full SHA
    04039a3 View commit details
    Browse the repository at this point in the history

  6. Convert back from protobuf to hookresult 

    Protobuf messages marshal to json differently than pure Go structs, so
I'm trying this out to see that has changed things in a way that is
breaking endtoend tests

Signed-off-by: Andrew Mason <amason@slack-corp.com>
    @ajm188
    ajm188 committed Oct 30, 2021
    Configuration menu
    Copy the full SHA
    5125f0b View commit details
    Browse the repository at this point in the history