Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Respect --allow-zero-in-date in CREATE and in -declarative migrations #9142

Merged

Conversation

shlomi-noach
Copy link
Contributor

Followup to #9089

This PR respects --allow-zero-in-date for ddl_strategy in the following:

  • Any CREATE TABLE statement, whether online or not
  • Any -declarative migration, whether it turns out to be an actual CREATE TABLE or an ALTER TABLE.

I believe this completes and covers all cases for --allow-zero-in-date.

endtoend tests added for validation.

Documentation PR to follow.

Checklist

  • Should this PR be backported?
  • Tests were added or are not required
  • Documentation was added or is not required

Deployment Notes

Signed-off-by: Shlomi Noach <2607934+shlomi-noach@users.noreply.github.com>
Signed-off-by: Shlomi Noach <2607934+shlomi-noach@users.noreply.github.com>
Signed-off-by: Shlomi Noach <2607934+shlomi-noach@users.noreply.github.com>
Signed-off-by: Shlomi Noach <2607934+shlomi-noach@users.noreply.github.com>
Signed-off-by: Shlomi Noach <2607934+shlomi-noach@users.noreply.github.com>
@shlomi-noach shlomi-noach added Type: Enhancement Logical improvement (somewhere between a bug and feature) Component: Query Serving release notes labels Nov 4, 2021
@shlomi-noach shlomi-noach merged commit 20d9777 into vitessio:main Nov 4, 2021
@shlomi-noach shlomi-noach deleted the allow-zero-in-date-create-table branch November 4, 2021 10:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Component: Query Serving Type: Enhancement Logical improvement (somewhere between a bug and feature)
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants