Inclusive naming: master->primary in topo package #9182
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: deepthi <deepthi@planetscale.com>
deepthi
requested review from
ajm188,
doeg,
rafael and
rohit-nayak-ps
as code owners
deepthi
requested review from
carsonoid and
mattlord
and removed request for
rafael,
doeg and
rohit-nayak-ps
deepthi
commented
Nov 10, 2021
| @@ -68,6 +68,9 @@ func startConsul(t *testing.T, authToken string) (*exec.Cmd, string, string) { | |||
| }, | |||
| } | |||
|
|
|||
| // TODO(deepthi): this is the legacy ACL format. We run v1.4.0 by default in which this has been deprecated. | |||
| // We should start using the new format | |||
| // https://learn.hashicorp.com/tutorials/consul/access-control-replication-multiple-datacenters?in=consul/security-operations | |||
| if authToken != "" { | |||
| config["datacenter"] = "vitess" | |||
| config["acl_datacenter"] = "vitess" | |||
There was a problem hiding this comment.
@gedgar @sonne5 is this something one of you can fix?
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
NewMasterParticipationNewLeaderParticipationNote: I verified that vitess-operator does not use any of the functions that are being renamed.
Related Issue(s)
Fixes #8620
Checklist
Deployment Notes