Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Delete go/cmd/automation_{client,server} #9234

Merged
merged 1 commit into from
Nov 21, 2021

Conversation

ajm188
Copy link
Contributor

@ajm188 ajm188 commented Nov 15, 2021

Signed-off-by: Andrew Mason amason@slack-corp.com

Description

Just a git rm -rf ./go/cmd/automation_{client,server}. I've never actually deleted a binary from vitess so I'm not sure if this is the right process (i.e. should we "deprecate" the binary by having it print a warning whenever you try to run it?)

Related Issue(s)

#9222

Checklist

  • Should this PR be backported? no
  • Tests were added or are not required n/a
  • Documentation was added or is not required n/a

Deployment Notes

Signed-off-by: Andrew Mason <amason@slack-corp.com>
@deepthi
Copy link
Member

deepthi commented Nov 15, 2021

I've never actually deleted a binary from vitess so I'm not sure if this is the right process (i.e. should we "deprecate" the binary by having it print a warning whenever you try to run it?)

In this case I think we are sure that these binaries are defunct.
For something like vtctlclient we will go through a proper deprecation cycle.

Why not delete the go/vt/automation package along with cmd/automation_*?

@ajm188
Copy link
Contributor Author

ajm188 commented Nov 18, 2021

Why not delete the go/vt/automation package along with cmd/automation_*?

It's used in a few other places, namely vtworker (which is also being deleted but will be a much larger diff):

❯ go list -f '{{ .ImportPath }}:{{ .Deps }}' ./... | grep 'go/vt/automation' | cut -d ':' -f1
vitess.io/vitess/go/cmd/automation_server
vitess.io/vitess/go/cmd/vtcombo
vitess.io/vitess/go/cmd/vtctld
vitess.io/vitess/go/vt/automation
vitess.io/vitess/go/vt/vtctld
vitess.io/vitess/go/vt/workflow/resharding
vitess.io/vitess/go/vt/workflow/reshardingworkflowgen

@deepthi deepthi merged commit 58b5237 into vitessio:main Nov 21, 2021
@ajm188 ajm188 deleted the delete-automationservice branch July 8, 2022 10:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Component: General Changes throughout the code base Type: Internal Cleanup
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants