Set super_read_only off during restore; achieves same as PR #8929 #9240
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…8929 Signed-off-by: Jacques Grove <aquarapid@gmail.com>
aquarapid
added
Type: Enhancement
3 tasks
deepthi
reviewed
Nov 17, 2021
will fail. Signed-off-by: Jacques Grove <aquarapid@gmail.com>
deepthi
reviewed
Nov 22, 2021
|
Ah nevermind; converting to SQLError won't work as you noted. I'll leave this as-is for now. |
systay
approved these changes
Nov 24, 2021
3 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In short, we are blindly setting
super_read_onlyoff in the restore flow, in case the default my.cnf params hassuper_read_only=ON. This allows us to populate our metadata tables without running into write issues.Tested manually and by the current DB restore e2e flow.