Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Match collation between VTGate and VTTablet #9248

Merged
merged 7 commits into from
Nov 17, 2021
Merged

Match collation between VTGate and VTTablet #9248

merged 7 commits into from
Nov 17, 2021

Conversation

frouioui
Copy link
Member

@frouioui frouioui commented Nov 16, 2021 •
edited
Loading

Description

This pull request enforces the collation match between VTGate and VTTablet.

Related Issue(s)

Checklist

  • Tests were added or are not required
  • Documentation was added or is not required

@frouioui
feat: enforce collation matching in vttablet
5aaade4 
Signed-off-by: Florent Poinsard <florent.poinsard@outlook.fr>
@frouioui frouioui added Type: Enhancement Logical improvement (somewhere between a bug and feature) Breaking change Component: Query Serving release notes labels Nov 16, 2021
@frouioui
feat: update how we treat default collation in vtgate
0d03d0a 
Signed-off-by: Florent Poinsard <florent.poinsard@outlook.fr>
@frouioui frouioui marked this pull request as ready for review November 17, 2021 11:02
@frouioui
refactor: revert comments
5290a2f 
Signed-off-by: Florent Poinsard <florent.poinsard@outlook.fr>
@frouioui
test: updated the expected output of TestStartBuildTabletFromInput
27a691b 
Signed-off-by: Florent Poinsard <florent.poinsard@outlook.fr>
@frouioui
Merge remote-tracking branch 'upstream/main' into match-collation
1cd5d7d 
Signed-off-by: Florent Poinsard <florent.poinsard@outlook.fr>
@frouioui
refactor: apply go fmt on files
8407980 
Signed-off-by: Florent Poinsard <florent.poinsard@outlook.fr>
@frouioui
feat: check if executor is nil before accessing it
c7e6895 
Signed-off-by: Florent Poinsard <florent.poinsard@outlook.fr>
vmg
vmg approved these changes Nov 17, 2021
View reviewed changes
Copy link
Collaborator

@vmg vmg left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I paired with @frouioui to design this and I'm happy with the result.

@frouioui frouioui merged commit d188c5e into vitessio:main Nov 17, 2021
@frouioui frouioui deleted the match-collation branch November 17, 2021 12:44
@frouioui frouioui mentioned this pull request Nov 17, 2021
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@vmg vmg vmg approved these changes

@deepthi deepthi Awaiting requested review from deepthi deepthi is a code owner

@GuptaManan100 GuptaManan100 Awaiting requested review from GuptaManan100 GuptaManan100 is a code owner

@harshit-gangal harshit-gangal Awaiting requested review from harshit-gangal harshit-gangal is a code owner

@rohit-nayak-ps rohit-nayak-ps Awaiting requested review from rohit-nayak-ps rohit-nayak-ps is a code owner

@shlomi-noach shlomi-noach Awaiting requested review from shlomi-noach shlomi-noach is a code owner

@systay systay Awaiting requested review from systay systay is a code owner

Assignees
No one assigned
Labels
Component: Query Serving Type: Enhancement Logical improvement (somewhere between a bug and feature)
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@frouioui @vmg