MoveTables: update vschema while moving tables with autoincrement from sharded to unsharded #9288
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
… to unsharded keyspace Signed-off-by: Rohit Nayak <rohit@planetscale.com>
Signed-off-by: Rohit Nayak <rohit@planetscale.com>
mattlord
reviewed
Nov 29, 2021
mattlord
reviewed
Nov 29, 2021
mattlord
reviewed
Nov 29, 2021
mattlord
reviewed
Nov 29, 2021
mattlord
approved these changes
Nov 29, 2021
deepthi
reviewed
Dec 1, 2021
Signed-off-by: Rohit Nayak <rohit@planetscale.com>
mattlord
approved these changes
Dec 5, 2021
| done = true | ||
| log.Infof("Workflow %s has started", ksWorkflow) | ||
| } | ||
| case <-time.After(5 * time.Second): |
There was a problem hiding this comment.
Minor nit, any reason to have the timeout this low? We risk causing the entire action/test to fail. I'm not sure more time is really needed, just curious. We could also make the wait time a parameter.
Feel free to ignore.
| } | ||
| output, err := vc.VtctlClient.ExecuteCommandWithOutput("Workflow", ksWorkflow, "show") | ||
| require.NoError(t, err) | ||
| if strings.Contains(output, "\"State\": \"Running\"") { |
There was a problem hiding this comment.
Minor nit, maybe better to use a RegEx or JSON parsing so that we are checking for what we really care about while resilient to whitespace and other minor format changes? Full JSON parsing is probably overkill, maybe RegEx is too :-)
Feel free to ignore.
Signed-off-by: Rohit Nayak <rohit@planetscale.com>
rohit-nayak-ps
force-pushed
the
rn-movetables-vschema-sequence
branch
from
d618519
to
dd042cf
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
When a sharded table with autoincrement is moved using MoveTables to an unsharded keyspace, currently the related sequence information is not carried over into the target (unsharded) keyspace's vschema.
This PR fixes that by copying over the sequence info from the source schema for that table. This is verified by adding this use-case to the v2 end-to-end test.
Signed-off-by: Rohit Nayak rohit@planetscale.com
Related Issue(s)
#9002
Checklist