CI: ubuntu-latest now has MySQL 8.0.26, let us override it with latest 8.0.x #9368
Conversation
Signed-off-by: deepthi <deepthi@planetscale.com>
|
I'm OK with this as a temporary workaround but it breaks a reasonable assumption here, that is: you install the latest official MySQL version with And even if it caused no immediate issues, not being able to rely on apt being able to manage the dependencies is likely to crop up in unexpected ways moving forward. This is one potential short-term option though, for sure. Others may be:
|
I'm reluctant to move everything back to 18.04, we had tried to actually move everything forward to 20.04 at some point but didn't complete that work, see #7850 |
Signed-off-by: deepthi <deepthi@planetscale.com>
deepthi
changed the title
…the latest Signed-off-by: deepthi <deepthi@planetscale.com>
| sudo DEBIAN_FRONTEND="noninteractive" apt-get update | ||
|
|
||
| # Uninstall any previously installed MySQL first | ||
| sudo systemctl stop apparmor | ||
| sudo DEBIAN_FRONTEND="noninteractive" apt-get remove -y --purge mysql-server mysql-client mysql-common | ||
| sudo apt-get -y autoremove | ||
| sudo apt-get -y autoclean | ||
| sudo deluser mysql | ||
| sudo rm -rf /var/lib/mysql | ||
| sudo rm -rf /etc/mysql | ||
|
|
There was a problem hiding this comment.
I don't any of this is necessary, is it? Any previous installation and its files don't matter as we use non-default values anyway and this will slow down the CI jobs further.
| sudo service mysql stop | ||
| sudo service etcd stop | ||
| sudo bash -c "echo '/usr/sbin/mysqld { }' > /etc/apparmor.d/usr.sbin.mysqld" # https://bugs.launchpad.net/ubuntu/+source/mariadb-10.1/+bug/1806263 |
There was a problem hiding this comment.
I would remove this. This was about running MariaDB after MySQL was previously installed -- which is not relevant for us here.
| sudo apt-get update | ||
| sudo apt-get install -y mysql-server mysql-client make unzip g++ etcd curl git wget eatmydata | ||
| sudo DEBIAN_FRONTEND="noninteractive" apt-get install -y mysql-server mysql-client |
There was a problem hiding this comment.
I would remove this and just keep the original apt-get install for all of our packages.
| sudo ln -s /etc/apparmor.d/usr.sbin.mysqld /etc/apparmor.d/disable/ | ||
| sudo apparmor_parser -R /etc/apparmor.d/usr.sbin.mysqld | ||
| sudo apparmor_parser -R /etc/apparmor.d/usr.sbin.mysqld || echo "could not remove mysqld profile" |
There was a problem hiding this comment.
If this step failing is not fatal, then why do it at all?
|
I'm going to merge this as-is to unblock everyone, and @mattlord will do a follow up PR cleaning up how we are installing mysql in some of the tests. |
| sudo DEBIAN_FRONTEND="noninteractive" apt-get update | ||
|
|
||
| # Uninstall any previously installed MySQL first | ||
| sudo systemctl stop apparmor | ||
| sudo DEBIAN_FRONTEND="noninteractive" apt-get remove -y --purge mysql-server mysql-client mysql-common | ||
| sudo apt-get -y autoremove | ||
| sudo apt-get -y autoclean | ||
| sudo deluser mysql | ||
| sudo rm -rf /var/lib/mysql | ||
| sudo rm -rf /etc/mysql |
There was a problem hiding this comment.
This is a generated file, so we should be changing the code generation and not the file directly. The file that generates this is ci_workflow_gen.go
|
Thank you both for looking into this! ❤️ |
Description
Actions workflows that run on
ubuntu-latesthave been failing for ~12 hours now.This is because of changes made to the images
actions/runner-images#4708
actions/runner-images#4674
Since the image already includes a mysql install, perhaps we can stop trying to install it ourselves.Let's try to install the latest 8.0.x version ourselves.
Related Issue(s)
Checklist
Deployment Notes