Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

vtctl: delete deprecated flag #9406

Merged
merged 1 commit into from
Dec 21, 2021
Merged

vtctl: delete deprecated flag #9406

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
11 changes: 0 additions & 11 deletions go/vt/vtctl/vtctl.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1666,17 +1666,6 @@ func commandSetShardTabletControl(ctx context.Context, wr *wrangler.Wrangler, su
cellsStr := subFlags.String("cells", "", "Specifies a comma-separated list of cells to update")
deniedTablesStr := subFlags.String("denied_tables", "", "Specifies a comma-separated list of tables to add to the denylist (used for vertical split). Each is either an exact match, or a regular expression of the form '/regexp/'.")

// DEPRECATION START: remove after 12.0
blacklistedTablesStr := subFlags.String("blacklisted_tables", "", "Specifies a comma-separated list of tables to add to the denylist (used for vertical split). Each is either an exact match, or a regular expression of the form '/regexp/'.")

if *deniedTablesStr != "" && *blacklistedTablesStr != "" {
return fmt.Errorf("cannot specify both denied_tables and blacklisted_tables")
}
if *deniedTablesStr == "" && *blacklistedTablesStr != "" {
*deniedTablesStr = *blacklistedTablesStr
}
// DEPRECATION ends

remove := subFlags.Bool("remove", false, "Removes cells for vertical splits.")
disableQueryService := subFlags.Bool("disable_query_service", false, "Disables query service on the provided nodes. This flag requires 'denied_tables' and 'remove' to be unset, otherwise it's ignored.")
if err := subFlags.Parse(args); err != nil {
Expand Down