Deprecate and ignore gateway_implementation flag to vtgate.
#9482
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: deepthi <deepthi@planetscale.com>
Signed-off-by: deepthi <deepthi@planetscale.com>
deepthi
requested review from
frouioui,
harshit-gangal and
systay
as code owners
6 tasks
deepthi
added
Component: Query Serving
release notes (needs details)
vmg
requested changes
Jan 11, 2022
go/vt/vtgate/gateway.go
Outdated
| // GatewayImplementation allows you to choose which gateway to use for vtgate routing. Defaults to tabletgateway, other option is discoverygateway | ||
| GatewayImplementation = flag.String("gateway_implementation", "tabletgateway", "Allowed values: discoverygateway (deprecated), tabletgateway (default)") | ||
| _ = flag.String("gateway_implementation", "", "Deprecated. Only tabletgateway is now supported, discoverygateway is no longer available") | ||
| GatewayImplementation = new(string) |
There was a problem hiding this comment.
just make this GatewayImplementation = &tabletGatewayImplementation instead of assigning to it from an init function.
There was a problem hiding this comment.
That doesn't work because tabletGatewayImplementation is declared as a const.
go/vt/vtgate/gateway.go:39:26: cannot take the address of tabletGatewayImplementation
There was a problem hiding this comment.
I could change the type of GatewayImplementation from string* to string and change all references, but that will touch lots of files. I'm looking for the minimum necessary change.
There was a problem hiding this comment.
@deepthi I see, in that case the minimal change would be making a temp assignment right next to it.
var defaultGatewayImplementation = tabletGatewayImplementation
var GatewayImplementation = &defaultGatewayImplementation
That's the minimal amount of changes and doesn't allocate on heap or use init,
Signed-off-by: deepthi <deepthi@planetscale.com>
Signed-off-by: deepthi <deepthi@planetscale.com>
vmg
approved these changes
Jan 13, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
VTGate's
gateway_implementationflag is now deprecated, and any value provided is ignored.tabletgatewayis now the only supported implementation.Related Issue(s)
#9218
Checklist
Deployment Notes
Scripts used to run
vtgatewill need to be updated to drop this flag. It will be removed in a future release (14.0)