Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Pass Semi sync information from durability policy and use it to log discrepancies #9533

Merged
merged 32 commits into from
Jan 25, 2022
Merged

Pass Semi sync information from durability policy and use it to log discrepancies #9533

merged 32 commits into from
Jan 25, 2022

Commits on Jan 13, 2022

  1. test: add an e2e test verifying that semi sync is setup correctly aft… 

    …er calling a reparent operation

Signed-off-by: Manan Gupta <manan@planetscale.com>
    @GuptaManan100
    GuptaManan100 committed Jan 13, 2022
    Configuration menu
    Copy the full SHA
    ae9deed View commit details
    Browse the repository at this point in the history

Commits on Jan 14, 2022

  1. feat: change PromoteReplica rpc to allow passing in semiSync as a par… 

    …ameter

Signed-off-by: Manan Gupta <manan@planetscale.com>
    @GuptaManan100
    GuptaManan100 committed Jan 14, 2022
    Configuration menu
    Copy the full SHA
    7cab69e View commit details
    Browse the repository at this point in the history

  2. feat: add semiSync as a parameter to fixSemiSync and use it log diffe… 

    …rences with enable_semi_sync flag

Signed-off-by: Manan Gupta <manan@planetscale.com>
    @GuptaManan100
    GuptaManan100 committed Jan 14, 2022
    Configuration menu
    Copy the full SHA
    f18174b View commit details
    Browse the repository at this point in the history

Commits on Jan 17, 2022

  1. feat: change parameter in fixSemiSync to be an enum 

    Signed-off-by: Manan Gupta <manan@planetscale.com>
    @GuptaManan100
    GuptaManan100 committed Jan 17, 2022
    Configuration menu
    Copy the full SHA
    5413fd5 View commit details
    Browse the repository at this point in the history

  2. feat: change InitReplica rpc to allow passing in semiSync as a parameter 

    Signed-off-by: Manan Gupta <manan@planetscale.com>
    @GuptaManan100
    GuptaManan100 committed Jan 17, 2022
    Configuration menu
    Copy the full SHA
    d93d77f View commit details
    Browse the repository at this point in the history

  3. feat: change InitPrimary rpc to allow passing in semiSync as a parameter 

    Signed-off-by: Manan Gupta <manan@planetscale.com>
    @GuptaManan100
    GuptaManan100 committed Jan 17, 2022
    Configuration menu
    Copy the full SHA
    0ba29a5 View commit details
    Browse the repository at this point in the history

  4. feat: fix demotePrimary function to fix primary side semi-sync only i… 

    …f enabled

Signed-off-by: Manan Gupta <manan@planetscale.com>
    @GuptaManan100
    GuptaManan100 committed Jan 17, 2022
    Configuration menu
    Copy the full SHA
    f87b857 View commit details
    Browse the repository at this point in the history

  5. feat: change UndoDemotePrimary rpc to allow passing in semiSync as a … 

    …parameter

Signed-off-by: Manan Gupta <manan@planetscale.com>
    @GuptaManan100
    GuptaManan100 committed Jan 17, 2022
    Configuration menu
    Copy the full SHA
    1377080 View commit details
    Browse the repository at this point in the history

  6. feat: change UndoDemoteMaster rpc to allow passing in semiSync as a p… 

    …arameter

Signed-off-by: Manan Gupta <manan@planetscale.com>
    @GuptaManan100
    GuptaManan100 committed Jan 17, 2022
    Configuration menu
    Copy the full SHA
    8f045dd View commit details
    Browse the repository at this point in the history

  7. feat: change SetReplicationSource rpc to allow passing in semiSync as… 

    … a parameter

Signed-off-by: Manan Gupta <manan@planetscale.com>
    @GuptaManan100
    GuptaManan100 committed Jan 17, 2022
    Configuration menu
    Copy the full SHA
    1de77a3 View commit details
    Browse the repository at this point in the history

  8. feat: change SetMaster rpc to allow passing in semiSync as a parameter 

    Signed-off-by: Manan Gupta <manan@planetscale.com>
    @GuptaManan100
    GuptaManan100 committed Jan 17, 2022
    Configuration menu
    Copy the full SHA
    036dbb5 View commit details
    Browse the repository at this point in the history

Commits on Jan 19, 2022

  1. Merge remote-tracking branch 'upstream/main' into semi-sync-durabilit… 

    …y-policy

Signed-off-by: Manan Gupta <manan@planetscale.com>
    @GuptaManan100
    GuptaManan100 committed Jan 19, 2022
    Configuration menu
    Copy the full SHA
    7a83481 View commit details
    Browse the repository at this point in the history

  2. feat: fix startReplication to not change semi-sync settings 

    Signed-off-by: Manan Gupta <manan@planetscale.com>
    @GuptaManan100
    GuptaManan100 committed Jan 19, 2022
    Configuration menu
    Copy the full SHA
    bad3a0c View commit details
    Browse the repository at this point in the history

  3. test: pass correct durability flag to vtctld in reparent tests 

    Signed-off-by: Manan Gupta <manan@planetscale.com>
    @GuptaManan100
    GuptaManan100 committed Jan 19, 2022
    Configuration menu
    Copy the full SHA
    1f83942 View commit details
    Browse the repository at this point in the history

Commits on Jan 22, 2022

  1. feat: fix changeTypeLocked to allow passing semiSync as a parameter 

    Signed-off-by: Manan Gupta <manan@planetscale.com>
    @GuptaManan100
    GuptaManan100 committed Jan 22, 2022
    Configuration menu
    Copy the full SHA
    f6ea84a View commit details
    Browse the repository at this point in the history

  2. feat: add durability flag to vtworker 

    Signed-off-by: Manan Gupta <manan@planetscale.com>
    @GuptaManan100
    GuptaManan100 committed Jan 22, 2022
    Configuration menu
    Copy the full SHA
    82e5a47 View commit details
    Browse the repository at this point in the history

  3. feat: fix StartReplication to allow passing semiSync as a parameter 

    Signed-off-by: Manan Gupta <manan@planetscale.com>
    @GuptaManan100
    GuptaManan100 committed Jan 22, 2022
    Configuration menu
    Copy the full SHA
    8ac91e1 View commit details
    Browse the repository at this point in the history

  4. Merge remote-tracking branch 'upstream/main' into semi-sync-durabilit… 

    …y-policy

Signed-off-by: Manan Gupta <manan@planetscale.com>
    @GuptaManan100
    GuptaManan100 committed Jan 22, 2022
    Configuration menu
    Copy the full SHA
    2fe8592 View commit details
    Browse the repository at this point in the history

  5. test: fix TestChangeTabletType to have the primary tablet setup in topo 

    Signed-off-by: Manan Gupta <manan@planetscale.com>
    @GuptaManan100
    GuptaManan100 committed Jan 22, 2022
    Configuration menu
    Copy the full SHA
    a696c98 View commit details
    Browse the repository at this point in the history

  6. test: fix TestStartReplication to have the primary tablet setup in topo 

    Signed-off-by: Manan Gupta <manan@planetscale.com>
    @GuptaManan100
    GuptaManan100 committed Jan 22, 2022
    Configuration menu
    Copy the full SHA
    c5e6136 View commit details
    Browse the repository at this point in the history

  7. test: add SettingDurabilityPolicies in init function for vtworker tests 

    Signed-off-by: Manan Gupta <manan@planetscale.com>
    @GuptaManan100
    GuptaManan100 committed Jan 22, 2022
    Configuration menu
    Copy the full SHA
    db477a1 View commit details
    Browse the repository at this point in the history

  8. test: SetDurabilityPolicies in endtoend tests for InitShardPrimary 

    Signed-off-by: Manan Gupta <manan@planetscale.com>
    @GuptaManan100
    GuptaManan100 committed Jan 22, 2022
    Configuration menu
    Copy the full SHA
    243bfc3 View commit details
    Browse the repository at this point in the history

  9. test: add semi-sync durability flag to all the e2e tests using semi-sync 

    Signed-off-by: Manan Gupta <manan@planetscale.com>
    @GuptaManan100
    GuptaManan100 committed Jan 22, 2022
    Configuration menu
    Copy the full SHA
    9fb94ec View commit details
    Browse the repository at this point in the history

  10. feat: In ChangeTabletType we should query the durability rules with t… 

    …he changed type and not with the original

Signed-off-by: Manan Gupta <manan@planetscale.com>
    @GuptaManan100
    GuptaManan100 committed Jan 22, 2022
    Configuration menu
    Copy the full SHA
    8a75a7b View commit details
    Browse the repository at this point in the history

  11. test: only add the durability flag to vtctl if major version exceeds 13 

    Signed-off-by: Manan Gupta <manan@planetscale.com>
    @GuptaManan100
    GuptaManan100 committed Jan 22, 2022
    Configuration menu
    Copy the full SHA
    128a52c View commit details
    Browse the repository at this point in the history

  12. feat: fix demotePrimary to preserve behaviour 

    Signed-off-by: Manan Gupta <manan@planetscale.com>
    @GuptaManan100
    GuptaManan100 committed Jan 22, 2022
    Configuration menu
    Copy the full SHA
    ffbef3f View commit details
    Browse the repository at this point in the history

  13. feat: do not log error messages when SemiSyncActionNone 

    Signed-off-by: Manan Gupta <manan@planetscale.com>
    @GuptaManan100
    GuptaManan100 committed Jan 22, 2022
    Configuration menu
    Copy the full SHA
    b19bdda View commit details
    Browse the repository at this point in the history

  14. test: add test for checking logs in fixSemiSync 

    Signed-off-by: Manan Gupta <manan@planetscale.com>
    @GuptaManan100
    GuptaManan100 committed Jan 22, 2022
    Configuration menu
    Copy the full SHA
    ddcaa78 View commit details
    Browse the repository at this point in the history

Commits on Jan 25, 2022

  1. refactor: rename ReplicaSemiSync to IsReplicaSemiSync 

    Signed-off-by: Manan Gupta <manan@planetscale.com>
    @GuptaManan100
    GuptaManan100 committed Jan 25, 2022
    Configuration menu
    Copy the full SHA
    41acb37 View commit details
    Browse the repository at this point in the history

  2. refactor: rename SemiSyncActions values 

    Signed-off-by: Manan Gupta <manan@planetscale.com>
    @GuptaManan100
    GuptaManan100 committed Jan 25, 2022
    Configuration menu
    Copy the full SHA
    a5d5e17 View commit details
    Browse the repository at this point in the history

  3. refactor: rename durability_policy flag 

    Signed-off-by: Manan Gupta <manan@planetscale.com>
    @GuptaManan100
    GuptaManan100 committed Jan 25, 2022
    Configuration menu
    Copy the full SHA
    411a983 View commit details
    Browse the repository at this point in the history

  4. refactor: add comment explaining the use of isPrimarySideSemiSyncEnabled 

    Signed-off-by: Manan Gupta <manan@planetscale.com>
    @GuptaManan100
    GuptaManan100 committed Jan 25, 2022
    Configuration menu
    Copy the full SHA
    79d2822 View commit details
    Browse the repository at this point in the history