Add durability flag in local examples #9579
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ere semi_sync is enabled Signed-off-by: Manan Gupta <manan@planetscale.com>
Signed-off-by: Manan Gupta <manan@planetscale.com>
GuptaManan100
added
Type: Enhancement
GuptaManan100
requested review from
deepthi and
rohit-nayak-ps
as code owners
deepthi
approved these changes
Jan 28, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
A new flag
-durability_policyfor vtctld was introduced and it should now be provided in the local examples. This PR accomplishes that change of adding the new flag to vtctld-up.sh in all the examples which are using semi-sync.We also start using PlannedReparentShard for cluster initialisation in the example.
The changes to the scripts have been tested locally by inserting data, reading it, performing failovers (both planned and emergency) and inserting and reading data again. I have also checked the logs and verified that everything is in order.
Related Issue(s)
Checklist
Deployment Notes