-
-
Notifications
You must be signed in to change notification settings - Fork 1.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Improve support for parallel runs and coverage report merging when --shard
option is used
#5125
Comments
The What you could do now is use similar unique name in |
We are indeed using |
--shard
option is used
As quick fix for this I think we could append the In longer term we'll need to think how to properly support all test and coverage reporters to work nicely with It also might be worth to check how Playwright generates test reports and coverage reports with |
It looks like playwright does shard-based file naming for their blob reporter automatically https://playwright.dev/docs/test-reporters#blob-reporter since it's intended be used with For Vitest, I'm not sure how much we need to proactively help avoiding filename conflict since we don't have such merging functionality out-of-the-box yet. Btw, I don't think playwright has coverage feature builtin microsoft/playwright#7030, microsoft/playwright#9208 |
Clear and concise description of the problem
I'm making this suggestion because currently my setup is the following:
--shard
option and run 4 instances of them in parallel usingnpm-run-all
(one for each shard)This setup worked fine up to version v1.2.1. But in v1.2.2, the change introduced in #5008 breaks it as we get errors like
Error: EONENT: No such file or directory, open '/.../.nyc_output/.tmp/coverage-184.json'
Suggested solution
Solution 1: Allow to customize the name of the
.tmp
directory so each instance can read/write on a different oneSolution 2: Make the auto-cleaning of
.tmp
optionalAlternative
No response
Additional context
No response
Validations
The text was updated successfully, but these errors were encountered: