chore: fix typescript performance #3030
Merged
+14
−26
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Great finding! I've also noticed that sometimes the IDE intellisense takes a while and can even stop working on a 16GB RAM. Restaring VSCode's Typescript server has restored the intellisense. Hopefully this fixes it. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I noticed we have a poor TS performance in the repo for quite some time now. I decided to check the performance on PC with 64GB, and it took a few seconds to update autocomplete 👀
tsc --generateTraceshowed thatdeepMergetakes a lot of time to process in thepools/child.tsfile:Now it's a lot better:
We don't really use the
deepMergetype merging, so I decided to just remove it.