Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(vitest): expose jsdom global if jsdom environment is enabled #5155

Merged
merged 3 commits into from
Feb 8, 2024

Conversation

sheremet-va
Copy link
Member

@sheremet-va sheremet-va commented Feb 8, 2024

Description

This PR adds a global jsdom variable that you can use to reconfigure the current environment if you use JSDOM:

jsdom.reconfigure({ url: 'https://examples.new.com' })

This is particularly useful in vmThreads and vmForks pool where you cannot reconfigure the current location by reassigning the variable.

If you need TypeScript to recognize it, add vitest/jsdom to your types in tsconfig.json file:

{
  "compilerOptions": {
    "types": ["vitest/jsdom"]
  }
}

Please don't delete this checklist! Before submitting the PR, please make sure you do the following:

  • It's really useful if your PR references an issue where it is discussed ahead of time. If the feature is substantial or introduces breaking changes without a discussion, PR might be closed.
  • Ideally, include a test that fails without this PR but passes with it.
  • Please, don't make changes to pnpm-lock.yaml unless you introduce a new test example.

Tests

  • Run the tests with pnpm test:ci.

Documentation

  • If you introduce new functionality, document it. You can run documentation with pnpm run docs command.

Changesets

  • Changes in changelog are generated from PR name. Please, make sure that it explains your changes in an understandable manner. Please, prefix changeset messages with feat:, fix:, perf:, docs:, or chore:.

Copy link

netlify bot commented Feb 8, 2024

Deploy Preview for fastidious-cascaron-4ded94 ready!

Name Link
🔨 Latest commit 5cc829e
🔍 Latest deploy log https://app.netlify.com/sites/fastidious-cascaron-4ded94/deploys/65c4d970710c7b000877a388
😎 Deploy Preview https://deploy-preview-5155--fastidious-cascaron-4ded94.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@sheremet-va sheremet-va merged commit 567d20b into vitest-dev:main Feb 8, 2024
4 checks passed
@sheremet-va sheremet-va deleted the feat/expose-jsdom branch February 8, 2024 14:03
@sheremet-va sheremet-va added this to the 1.3.0 milestone Feb 9, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant