-
Notifications
You must be signed in to change notification settings - Fork 0
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[202012] [Mellanox] [SKU] Mellanox-SN4700-V48C32 SKU added #31
Conversation
- Why I did it New SKU for MSN-4700 Platform i.e. Mellanox-SN4700-C128 Requirements: * Breakout: Port 1-32: 4x100G * Downlinks: 120 (1-30) * Uplinks: 8 (31-32) * Shared Headroom: Enabled * Over Subscribe Ratio: 1:8 * Default Topology: T2 * Default Cable Length for T2: 1500m * QoS params: The default ones defined in qos_config.j2 will be applied * Small Packet Percentage: Used 50% for traditional buffer model Note: For dynamic model, the value defined in LOSSLESS_TRAFFIC_PATTERN|AZURE|small_packet_percentage is used Additional Details: Switch Type has to be programmed as SpineRouter through config_db.json in DEVICE_METADATA|localhost|type field for the buffer values & cable lengths defined in the buffers_defaults_t2.j2 to apply on the device Cable Lengths Used for generating buffer_defaults_{t0,t1,t2}.j2 values Signed-off-by: Vivek Reddy Karri <vkarri@nvidia.com>
Signed-off-by: Vivek Reddy <vkarri@nvidia.com>
Signed-off-by: Vivek Reddy <vkarri@nvidia.com>
This reverts commit 11bfca2.
)" This reverts commit 74c82d5.
…to sku_4700_lnskus
Signed-off-by: Vivek Reddy <vkarri@nvidia.com>
Signed-off-by: Vivek Reddy <vkarri@nvidia.com>
@stephenxs, @assafho Please review |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
As comments.
Buffer pool sizes are correct.
@@ -0,0 +1,41 @@ | |||
## |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Let's make this file a symbol link to ../Mellanox-SN4700-C128/pg_profile_lookup.ini
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Will update
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Updated
show buffer configuration is showing the following PG profile: 100G is used for uplinks, so it should use the 1500m profile. |
For the traditional buffer model, the name doesn't matter as we've already calculated size, xoff, xon based on 1500m value in pg_profile_ini. The name is derived here based on the default_length we use, which can only be one value and thus set to 300 here. @stephenxs correct me if i'm wrong. Although, thanks for pointing out. I'll make some changes to accomodate correct naming scheme. I'll add this to the .j2 file
But for the correct naming to happen, user has to populate DEVICE_NEIGHBOR_METADATA table for each front panel interface specifying it's own role and neighbors role. |
Signed-off-by: Vivek Reddy <vkarri@nvidia.com>
Basically, you are correct except that we need both |
* [BFN] Canceling PSU platform API calls on SIGTERM Signed-off-by: Andriy Kokhan <andriyx.kokhan@intel.com> * [BFN] Fixed SONiC fwutil exec time (#31) Signed-off-by: Taras Keryk <tarasx.keryk@intel.com> Signed-off-by: Andriy Kokhan <andriyx.kokhan@intel.com> Signed-off-by: Taras Keryk <tarasx.keryk@intel.com> Co-authored-by: Taras Keryk <tarasx.keryk@intel.com>
Signed-off-by: Vivek Reddy Karri vkarri@nvidia.com
Why I did it
A new SKU for MSN4700 Platform i.e. Mellanox-SN4700-V48C32
Requirements:
Port 1-24: 2x200G
Port 25-32: 4x100G
Additional Details:
LOSSLESS_TRAFFIC_PATTERN|AZURE|small_packet_percentage
is usedbuffer_defaults_{t0,t1}.j2
valuesHow I did it
How to verify it
Which release branch to backport (provide reason below if selected)
Description for the changelog
Link to config_db schema for YANG module changes
A picture of a cute animal (not mandatory but encouraged)
syslog.gz