From eadf6da7c6507ff16576b4dbf088c4eec7578e1d Mon Sep 17 00:00:00 2001 From: MurakamiShinyu Date: Thu, 21 Nov 2024 23:02:14 +0900 Subject: [PATCH 1/4] feat: Update Playwright to 1.49.0 (Chromium 131.0.6778.33) --- package.json | 2 +- yarn.lock | 8 ++++---- 2 files changed, 5 insertions(+), 5 deletions(-) diff --git a/package.json b/package.json index 4ae94936..8b778a20 100644 --- a/package.json +++ b/package.json @@ -49,7 +49,7 @@ "node-stream-zip": "^1.14.0", "ora": "^5.4.1", "pdf-lib": "^1.16.0", - "playwright-core": "1.48.1", + "playwright-core": "1.49.0", "portfinder": "^1.0.28", "press-ready": "^4.0.3", "prettier": "^3.3.3", diff --git a/yarn.lock b/yarn.lock index e8a7a704..fa865e19 100644 --- a/yarn.lock +++ b/yarn.lock @@ -6390,10 +6390,10 @@ pify@^3.0.0: resolved "https://registry.yarnpkg.com/pify/-/pify-3.0.0.tgz#e5a4acd2c101fdf3d9a4d07f0dbc4db49dd28176" integrity sha512-C3FsVNH1udSEX48gGX1xfvwTWfsYWj5U+8/uK15BGzIGrKoUpghX8hWZwa/OFnakBiiVNmBvemTJR5mcy7iPcg== -playwright-core@1.48.1: - version "1.48.1" - resolved "https://registry.yarnpkg.com/playwright-core/-/playwright-core-1.48.1.tgz#5fe28fb9a9326dae88d4608c35e819163cceeb23" - integrity sha512-Yw/t4VAFX/bBr1OzwCuOMZkY1Cnb4z/doAFSwf4huqAGWmf9eMNjmK7NiOljCdLmxeRYcGPPmcDgU0zOlzP0YA== +playwright-core@1.49.0: + version "1.49.0" + resolved "https://registry.yarnpkg.com/playwright-core/-/playwright-core-1.49.0.tgz#8e69ffed3f41855b854982f3632f2922c890afcb" + integrity sha512-R+3KKTQF3npy5GTiKH/T+kdhoJfJojjHESR1YEWhYuEKRVfVaxH3+4+GvXE5xyCngCxhxnykk0Vlah9v8fs3jA== portfinder@^1.0.28: version "1.0.28" From 7f5ac04f97872e3d2ab81c4df1d39278bff3f765 Mon Sep 17 00:00:00 2001 From: spring-raining Date: Tue, 26 Nov 2024 00:37:48 +0900 Subject: [PATCH 2/4] chore: Force to set devicePixelRatio=1 in headless Chrome #357 --- src/browser.ts | 2 ++ 1 file changed, 2 insertions(+) diff --git a/src/browser.ts b/src/browser.ts index 4e6af9ca..703524d1 100644 --- a/src/browser.ts +++ b/src/browser.ts @@ -44,6 +44,8 @@ export async function launchBrowser({ '--allow-file-access-from-files', disableWebSecurity ? '--disable-web-security' : '', disableDevShmUsage ? '--disable-dev-shm-usage' : '', + // #357: Set devicePixelRatio=1 otherwise it causes layout issues in HiDPI displays + headless ? '--force-device-scale-factor=1' : '', // set Chromium language to English to avoid locale-dependent issues (e.g. minimum font size) '--lang=en', ...(!headless && process.platform === 'darwin' From da522f7aad8d45e5ea1e77c7778ad450b6a6034e Mon Sep 17 00:00:00 2001 From: spring-raining Date: Tue, 26 Nov 2024 01:02:10 +0900 Subject: [PATCH 3/4] fix: Fix to work `--browser` option fix #546 --- src/browser.ts | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-) diff --git a/src/browser.ts b/src/browser.ts index 703524d1..19e33ef8 100644 --- a/src/browser.ts +++ b/src/browser.ts @@ -81,9 +81,9 @@ export function checkBrowserAvailability(path: string): boolean { } export function isPlaywrightExecutable(path: string): boolean { - return registry - .executables() - .some((exe) => pathEquals(exe.executablePath() ?? '', path)); + return [playwright.chromium, playwright.firefox, playwright.webkit].some( + (exe) => pathEquals(exe.executablePath() ?? '', path), + ); } export async function downloadBrowser( From 2ad960c4583f6c7b090069969706c55bf11d98f6 Mon Sep 17 00:00:00 2001 From: spring-raining Date: Tue, 26 Nov 2024 01:06:08 +0900 Subject: [PATCH 4/4] chore: Update install Chromium step --- .github/workflows/test.yml | 2 +- package.json | 2 +- 2 files changed, 2 insertions(+), 2 deletions(-) diff --git a/.github/workflows/test.yml b/.github/workflows/test.yml index f21ab9cc..b653108d 100644 --- a/.github/workflows/test.yml +++ b/.github/workflows/test.yml @@ -22,7 +22,7 @@ jobs: with: node-version: ${{ matrix.node }} - run: yarn install - - run: yarn playwright-core install chromium + - run: yarn playwright-core install chromium --no-shell - run: yarn build - run: yarn test build-and-push-image: diff --git a/package.json b/package.json index 8b778a20..4a94d20d 100644 --- a/package.json +++ b/package.json @@ -12,7 +12,7 @@ "clean": "shx rm -rf dist tmp", "dev": "tsc -w --preserveWatchOutput", "example": "yarn --cwd example build", - "pretest": "playwright-core install chromium", + "pretest": "playwright-core install chromium --no-shell", "release": "release-it", "release:pre": "release-it --preRelease --npm.tag=next", "test": "vitest run --coverage",