Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

parser: implement MyEnum.from generic static method #20411

Merged
merged 10 commits into from
Jan 20, 2024
Merged

parser: implement MyEnum.from generic static method #20411

merged 10 commits into from
Jan 20, 2024

Conversation

spytheman
Copy link
Member

  • parser: implement Enum.from(123)! and Enum.from(abc)!
  • parser: cleanup the implementation of p.codegen/1
  • debug and add tests

@spytheman spytheman changed the title implement MyEnum.from static method parser: implement MyEnum.from generic static method Jan 6, 2024
JalonSolov
JalonSolov reviewed Jan 6, 2024
View reviewed changes
vlib/v/ast/ast.v Outdated Show resolved Hide resolved
@spytheman @JalonSolov
Update vlib/v/ast/ast.v
d1974d8 
Co-authored-by: JalonSolov <JalonSolov@gmail.com>
@JalonSolov
Copy link
Contributor

Hmm... if we had this, then #20589 wouldn't be needed. May still be useful in some cases, but not needed.

@spytheman spytheman merged commit 629bae4 into vlang:master Jan 20, 2024
54 checks passed
@spytheman spytheman deleted the implement__MyEnum.from__static_method branch January 20, 2024 10:16
kbkpbot pushed a commit to kbkpbot/v that referenced this pull request Jan 21, 2024
@spytheman @kbkpbot
parser: implement MyEnum.from(1)! generic static method (vlang#20411)
4966d51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@JalonSolov JalonSolov JalonSolov left review comments

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@spytheman @JalonSolov