Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

checker: check right type is option before appending to array #20573

Merged
merged 4 commits into from
Jan 19, 2024
Merged

checker: check right type is option before appending to array #20573

merged 4 commits into from
Jan 19, 2024

Conversation

Delta456
Copy link
Member

Fixes #20568

@Delta456 Delta456 marked this pull request as draft January 17, 2024 21:40
@Delta456 Delta456 marked this pull request as ready for review January 19, 2024 14:44
spytheman
spytheman approved these changes Jan 19, 2024
View reviewed changes
Copy link
Member

@spytheman spytheman left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Excellent work.

@spytheman spytheman merged commit d744314 into vlang:master Jan 19, 2024
54 checks passed
@Delta456 Delta456 deleted the checker_array_append_right_unwrap branch January 19, 2024 17:36
kbkpbot pushed a commit to kbkpbot/v that referenced this pull request Jan 21, 2024
@Delta456 @kbkpbot
checker: disallow non_opt_array << optvalue (vlang#20573)
84674c1
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@spytheman spytheman spytheman approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

C error when trying to append ?Foobar into an array of Foobar
2 participants
@Delta456 @spytheman