Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

checker: fix .variant smartcast on non-comptime variables #20575

Merged
merged 4 commits into from
Jan 20, 2024
Merged

checker: fix .variant smartcast on non-comptime variables #20575

merged 4 commits into from
Jan 20, 2024

Conversation

felipensp
Copy link
Member 

type TestSum = int | bool

fn main() {
    a := TestSum(true)
    $for v in TestSum.variants {
        if a is v {
                dump(a)
        }
    }    
}

@felipensp felipensp marked this pull request as ready for review January 20, 2024 01:15
spytheman
spytheman approved these changes Jan 20, 2024
View reviewed changes
Copy link
Member

@spytheman spytheman left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Excellent work.

@spytheman spytheman merged commit 9092d7f into vlang:master Jan 20, 2024
54 checks passed
kbkpbot pushed a commit to kbkpbot/v that referenced this pull request Jan 21, 2024
@felipensp @kbkpbot
checker: fix .variant smartcast on non-comptime variables (vlang#20575)
19e4bf0
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@spytheman spytheman spytheman approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@felipensp @spytheman