Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

io: ensure BufferedReader.read_line() returns io.Eof #20619

Merged
merged 1 commit into from
Jan 23, 2024

Conversation

pierrec
Copy link
Contributor

@pierrec pierrec commented Jan 21, 2024

BufferedReader.read_line() used to return error('none') upon reaching the end of the stream instead return io.Eof.

Copy link
Member

@spytheman spytheman left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Excellent work.

@spytheman
Copy link
Member

I do not get it 🤷🏻‍♂️ . I had already formatted vlib/io/custom_string_reading_test.v and pushed it here, and then you force pushed again, overwriting the formatted file 🤔 again.

@spytheman
Copy link
Member

Please do run v fmt -w vlib/io/custom_string_reading_test.v and push the change.

@pierrec
Copy link
Contributor Author

pierrec commented Jan 22, 2024

I do not get it 🤷🏻‍♂️ . I had already formatted vlib/io/custom_string_reading_test.v and pushed it here, and then you force pushed again, overwriting the formatted file 🤔 again.

Sorry, I pushed while being on the wrong branch.

Signed-off-by: Pierre Curto <pierre.curto@gmail.com>
@spytheman spytheman merged commit 14c2e4c into vlang:master Jan 23, 2024
37 of 42 checks passed
@pierrec pierrec deleted the bufferreaderreadlineeof branch January 27, 2024 16:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants