Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fmt: fix import selective with interface implements (fix #22200) #22209

Merged
merged 1 commit into from
Sep 13, 2024

Conversation

yuyi98
Copy link
Member

@yuyi98 yuyi98 commented Sep 13, 2024

This PR fix import selective with interface implements (fix #22200).

  • Fix import selective with interface implements.
  • Add test.

vlib\v\fmt\tests\import_selective_with_implements_keep.vv

import v.ast.walker { Visitor }
import v.ast { Node }

struct Walker implements Visitor {
	aaa string
}

fn (mut n Walker) visit(node &Node) ! {
	panic('not implemented')
}

Copy link
Member

@spytheman spytheman left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good work.

@spytheman spytheman merged commit 637ce20 into vlang:master Sep 13, 2024
66 of 67 checks passed
@yuyi98 yuyi98 deleted the fix_fmt_import branch September 13, 2024 12:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

vfmt removes selective import of interface when used only in implements clause
2 participants