add torch nightly in ci #87
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
huydhn
reviewed
Apr 22, 2025
scripts/test-template-ci.j2
Outdated
| {% endif %} | ||
| {% endfor %} | ||
|
|
||
| - group: "vllm against torch nightly" |
There was a problem hiding this comment.
Just curious if we can use the matrix parameter here to run stable and nightly side by side instead of copy/paste the CI steps. It seems doable if we could set soft_fail dynamically. What do you think?
There was a problem hiding this comment.
hmm, I wonder if it's possible,so we only want the nightlyto be triggered manually only, let me try it to see if it's possible
There was a problem hiding this comment.
add macro functions to wrap configs that can be used for both vllm against torch nightly and normal vllm.
Notice, kevin is working on use python script to generate the yaml file for test, so this jinja template thing will be deprecated in h2
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.